You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/20 17:36:14 UTC
[GitHub] [airflow] boredland opened a new pull request #20429: fix(standalone): remove hardcoded webserver-port
boredland opened a new pull request #20429:
URL: https://github.com/apache/airflow/pull/20429
Port 8080 is the default port for webserver (https://airflow.apache.org/docs/apache-airflow/stable/cli-and-env-variables-ref.html?highlight=webserver#webserver). By setting it here again explicitly, we forbid users to override it using AIRFLOW__WEBSERVER__WEB_SERVER_PORT. Removing it IMO is not a breaking change, since it will still default to 8080.
I tested locally if it still spins up the web server at port 8080. It did.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boredland edited a comment on pull request #20429: fix(standalone): remove hardcoded webserver-port
Posted by GitBox <gi...@apache.org>.
boredland edited a comment on pull request #20429:
URL: https://github.com/apache/airflow/pull/20429#issuecomment-998186862
> add to docs how to override port
as we spoke about what I as a user would have expected: I found the configuration variables page and expected them to "just work". So from my perspective a hint to that page is even more than enough. Let me know if you'd like to here more.
For people stumbling upon this as long as it isn't merged/released and like me are using standalone in a docker context, you can extend from the image and apply this tiny patch:
```Dockerfile
FROM apache/airflow:2.2.2-python3.9
## All airflow.cfg options can be set via environment variables
## See: https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html
ENV AIRFLOW__WEBSERVER__WEB_SERVER_PORT=${PORT:-5000}
COPY app.json ./
# TODO: remove when https://github.com/apache/airflow/pull/20429 is merged and released
RUN sed -i -e 's/, "--port", "8080"//g' /home/airflow/.local/lib/python3.9/site-packages/airflow/cli/commands/standalone_command.py
CMD ["airflow", "standalone"]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boredland commented on pull request #20429: fix(standalone): remove hardcoded webserver-port
Posted by GitBox <gi...@apache.org>.
boredland commented on pull request #20429:
URL: https://github.com/apache/airflow/pull/20429#issuecomment-998186862
> add to docs how to override port
as we spoke about what I as a user would have expected: I found the configuration variables page and expected them to "just work". So from my perspective a hint to that page is even more than enough. Let me know if you'd like to here more.
For people stumbling upon this as long as it isn't merged/released and like me are using standalone in a docker context, you can extend from the Docker like to to apply this tiny patch:
```Dockerfile
FROM apache/airflow:2.2.2-python3.9
## All airflow.cfg options can be set via environment variables
## See: https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html
ENV AIRFLOW__WEBSERVER__WEB_SERVER_PORT=${PORT:-5000}
COPY app.json ./
# TODO: remove when https://github.com/apache/airflow/pull/20429 is merged and released
RUN sed -i -e 's/, "--port", "8080"//g' /home/airflow/.local/lib/python3.9/site-packages/airflow/cli/commands/standalone_command.py
CMD ["airflow", "standalone"]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #20429: fix(standalone): remove hardcoded webserver-port
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #20429:
URL: https://github.com/apache/airflow/pull/20429#issuecomment-998135609
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20429: fix(standalone): remove hardcoded webserver-port
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20429:
URL: https://github.com/apache/airflow/pull/20429#issuecomment-998203452
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boredland edited a comment on pull request #20429: fix(standalone): remove hardcoded webserver-port
Posted by GitBox <gi...@apache.org>.
boredland edited a comment on pull request #20429:
URL: https://github.com/apache/airflow/pull/20429#issuecomment-998186862
> add to docs how to override port
as we spoke about what I as a user would have expected: I found the configuration variables page and expected them to "just work". So from my perspective a hint to that page is even more than enough. Let me know if you'd like me to add more.
For people stumbling upon this as long as it isn't merged/released and like me are using standalone in a docker context, you can extend from the image and apply this tiny patch:
```Dockerfile
FROM apache/airflow:2.2.2-python3.9
## All airflow.cfg options can be set via environment variables
## See: https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html
ENV AIRFLOW__WEBSERVER__WEB_SERVER_PORT=${PORT:-5000}
COPY app.json ./
# TODO: remove when https://github.com/apache/airflow/pull/20429 is merged and released
RUN sed -i -e 's/, "--port", "8080"//g' /home/airflow/.local/lib/python3.9/site-packages/airflow/cli/commands/standalone_command.py
CMD ["airflow", "standalone"]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #20429: fix(standalone): remove hardcoded webserver-port
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #20429:
URL: https://github.com/apache/airflow/pull/20429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #20429: fix(standalone): remove hardcoded webserver-port
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #20429:
URL: https://github.com/apache/airflow/pull/20429#issuecomment-998862161
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org