[GitHub] alamar commented on a change in pull request #3461: IGNITE-7309 Throw NodeStoppingException if marshaling fails while node stopping

[GitBox <gi...@apache.org>]

alamar commented on a change in pull request #3461: IGNITE-7309 Throw NodeStoppingException if marshaling fails while node stopping
URL: https://github.com/apache/ignite/pull/3461#discussion_r248264635
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/job/GridJobWorker.java
 ##########
 @@ -993,6 +994,23 @@ else if (!internal && ctx.event().isRecordable(EVT_JOB_FAILED))
         }
     }
 
+    /**
+     * This method wraps U.error invocations to check node stopping.
+     * Log message will be skipped if node is stopping and debug is disabled.
+     *
+     * @param msg Message to log using quiet logger.
+     * @param e Optional exception.
+     */
+    private void logError(String msg, @Nullable Throwable e) {
+        if (e != null) {
 
 Review comment:
   Can be rephrased as if (e != null && (log.isDebugEnabled() || !X.hasCause(e, NodeStoppingException.class)))

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services