You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/12/14 01:17:25 UTC

[GitHub] sijie commented on a change in pull request #3179: [Pulsar-IO] Add Netty Tcp Source Support

sijie commented on a change in pull request #3179: [Pulsar-IO] Add Netty Tcp Source Support
URL: https://github.com/apache/pulsar/pull/3179#discussion_r241618154
 
 

 ##########
 File path: site2/docs/io-tcp.md
 ##########
 @@ -0,0 +1,18 @@
+---
+id: io-tcp
+title: Netty Tcp Connector
+sidebar_label: Netty Tcp Connector
+---
+
+## Source
+
+The Netty Tcp Source connector is used to listen Tcp messages from
 
 Review comment:
   I would suggest adding a comment - this connector is suggested to be used in a containerized (e.g. k8s) deployment. otherwise, if the connector is running in process or thread mode, the instances will be conflicting on listening to ports.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services