You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by rj...@apache.org on 2014/01/24 15:31:02 UTC
svn commit: r1561023 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: rjung
Date: Fri Jan 24 14:31:02 2014
New Revision: 1561023
URL: http://svn.apache.org/r1561023
Log:
And then there were three (and a comment).
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1561023&r1=1561022&r2=1561023&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Jan 24 14:31:02 2014
@@ -32,7 +32,7 @@ PATCHES PROPOSED TO BACKPORT:
* Correct Maven dependencies
http://people.apache.org/~markt/patches/2014-01-23-poms-tc6-v1.patch
- +1: markt, kkolinko
+ +1: markt, kkolinko, rjung
-1:
* Update sample Eclipse IDE project to use JUnit 4 and
@@ -40,15 +40,17 @@ PATCHES PROPOSED TO BACKPORT:
when several JDKs are configured.
Remove unused JUnit-related properties from Ant build files.
https://people.apache.org/~kkolinko/patches/2014-01-24_tc6_junit4_eclipse.patch
- +1: kkolinko, markt
+ +1: kkolinko, markt, rjung
-1:
+ rjung: there are some additional junit references in file test/build.xml.
+ I wasn't able to make them work. Maybe more cleanup opportunity?
* Remove a stale empty test class from tribes tests.
It does nothing, has no references.
JUnit complains about it with "junit.framework.AssertionFailedError: No tests found"
svn rm test/org/apache/catalina/tribes/test/interceptors/TestTwoPhaseCommit.java
- +1: kkolinko, markt
+ +1: kkolinko, markt, rjung
-1:
* Align ROOT/index.html and ROOT/index.jsp
@@ -66,13 +68,13 @@ PATCHES PROPOSED TO BACKPORT:
page on the site, so that people have a chance to read instructions there.
https://people.apache.org/~kkolinko/patches/2014-01-24_tc6_ROOT_index.patch
- +1: kkolinko, markt
+ +1: kkolinko, markt, rjung
-1:
* Remove second copy of RUNNING.txt from the full-docs distribution.
(Backport of r981845)
https://people.apache.org/~kkolinko/patches/2014-01-24_tc6_fulldocs_RUNNING.patch
- +1: kkolinko, markt
+ +1: kkolinko, markt, rjung
-1:
PATCHES/ISSUES THAT ARE STALLED:
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1561023 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Rainer Jung <ra...@kippdata.de>.
On 24.01.2014 15:50, Konstantin Kolinko wrote:
> 2014/1/24 <rj...@apache.org>:
>> Author: rjung
>> Date: Fri Jan 24 14:31:02 2014
>> New Revision: 1561023
>>
>> URL: http://svn.apache.org/r1561023
>> Log:
>> And then there were three (and a comment).
>>
>> Modified:
>> tomcat/tc6.0.x/trunk/STATUS.txt
>
>>
>> * Update sample Eclipse IDE project to use JUnit 4 and
>> @@ -40,15 +40,17 @@ PATCHES PROPOSED TO BACKPORT:
>> when several JDKs are configured.
>> Remove unused JUnit-related properties from Ant build files.
>> https://people.apache.org/~kkolinko/patches/2014-01-24_tc6_junit4_eclipse.patch
>> - +1: kkolinko, markt
>> + +1: kkolinko, markt, rjung
>> -1:
>> + rjung: there are some additional junit references in file test/build.xml.
>> + I wasn't able to make them work. Maybe more cleanup opportunity?
>
>
> I've run the current tests directly in Eclipse IDE with
> 1. select "/test"
> 2. right-click
> 3. Run As > JUnit test
OK
> Regarding test/build.xml, I am leaving it as is at the moment and am
> fixing only those build files that we actually use.
>
> Technically in test/build.xml:
> 1. I suspect that <path id="tomcat.test.classpath"> may need additional
> jars beyond "tomcat-juli.jar" and "tomcat-coyote.jar"
> 2. Latest versions of JUnit 4 (4.9 and later?) have separate junit.jar
> and hamcrest.jar. Technically
> the build.xml does not specify, what version of JUnit it is using.
>
> As the general roadmap I would like to include tests into main
> build.xml, but as all current tests are standalone ones (they do not
> run Tomcat), I feel no urge for that. They can be successfully run
> from within IDE.
>
> Technically, I started tomcat6-testing branch to widen testing in
> Tomcat 6, but it is not ready yet.
> Though it have been useful during several backports.
> https://svn.apache.org/repos/asf/tomcat/tc6.0.x/branches/tomcat6-testing/BRANCH-README.txt
Thanks for the precise info Konstantin.
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1561023 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Konstantin Kolinko <kn...@gmail.com>.
2014/1/24 <rj...@apache.org>:
> Author: rjung
> Date: Fri Jan 24 14:31:02 2014
> New Revision: 1561023
>
> URL: http://svn.apache.org/r1561023
> Log:
> And then there were three (and a comment).
>
> Modified:
> tomcat/tc6.0.x/trunk/STATUS.txt
>
> * Update sample Eclipse IDE project to use JUnit 4 and
> @@ -40,15 +40,17 @@ PATCHES PROPOSED TO BACKPORT:
> when several JDKs are configured.
> Remove unused JUnit-related properties from Ant build files.
> https://people.apache.org/~kkolinko/patches/2014-01-24_tc6_junit4_eclipse.patch
> - +1: kkolinko, markt
> + +1: kkolinko, markt, rjung
> -1:
> + rjung: there are some additional junit references in file test/build.xml.
> + I wasn't able to make them work. Maybe more cleanup opportunity?
I've run the current tests directly in Eclipse IDE with
1. select "/test"
2. right-click
3. Run As > JUnit test
Regarding test/build.xml, I am leaving it as is at the moment and am
fixing only those build files that we actually use.
Technically in test/build.xml:
1. I suspect that <path id="tomcat.test.classpath"> may need additional
jars beyond "tomcat-juli.jar" and "tomcat-coyote.jar"
2. Latest versions of JUnit 4 (4.9 and later?) have separate junit.jar
and hamcrest.jar. Technically
the build.xml does not specify, what version of JUnit it is using.
As the general roadmap I would like to include tests into main
build.xml, but as all current tests are standalone ones (they do not
run Tomcat), I feel no urge for that. They can be successfully run
from within IDE.
Technically, I started tomcat6-testing branch to widen testing in
Tomcat 6, but it is not ready yet.
Though it have been useful during several backports.
https://svn.apache.org/repos/asf/tomcat/tc6.0.x/branches/tomcat6-testing/BRANCH-README.txt
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org