[jira] Commented: (HBASE-3613) NPE in MemStoreFlusher

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-3613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005483#comment-13005483 ] 

stack commented on HBASE-3613:
------------------------------

Did you swap the content of the 'if' test?  You put bestAnyRegion on RHS in your version when its on LHS in what you replace.

See below:

{code}

-      if (bestAnyRegion.memstoreSize.get() > 2 * bestFlushableRegion.memstoreSize.get()) {
+      HRegion regionToFlush = bestAnyRegion;
+      // UNLESS.... bestFlushableRegion is twice as large as bestAnyRegion.
+      if (bestFlushableRegion != null &&
+          2 * bestFlushableRegion.memstoreSize.get() > bestAnyRegion.memstoreSize.get()) {

{code}

> NPE in MemStoreFlusher
> ----------------------
>
>                 Key: HBASE-3613
>                 URL: https://issues.apache.org/jira/browse/HBASE-3613
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.1
>            Reporter: ryan rawson
>             Fix For: 0.90.2
>
>         Attachments: HBASE-3613.txt
>
>
> every now and again in a 0.90.1-2 load run I get a NPE on this line:
>       if (bestAnyRegion.memstoreSize.get() > 2 * bestFlushableRegion.memstoreSize.get()) {

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira