[GitHub] [helix] zhangmeng916 commented on a change in pull request #917: minor fix for customized view aggregation

[GitBox <gi...@apache.org>]

zhangmeng916 commented on a change in pull request #917: minor fix for customized view aggregation
URL: https://github.com/apache/helix/pull/917#discussion_r399571323
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/controller/stages/CustomizedViewAggregationStage.java
 ##########
 @@ -119,6 +117,7 @@ public void execute(final ClusterEvent event) throws Exception {
               "Failed to calculate customized view for resource " + resource.getResourceName(), ex);
         }
       }
+      updatedCustomizedViews.clear();
 
 Review comment:
   It's a variable defined outside state type for loop. If we do not clear it, it actually contains resource -> customized view mapping for all state types. When we update ZK, there's problem as we are updating state by state. 
   But I actually found this change is ugly, so I just moved the list inside the loop.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org