You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "moonchen (via GitHub)" <gi...@apache.org> on 2025/10/20 15:15:50 UTC
[PR] traffic_cache: use Regex in url_matcher port [trafficserver]
moonchen opened a new pull request, #12585:
URL: https://github.com/apache/trafficserver/pull/12585
This match is a single regex match. DFA is meant for multiple regex matching.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] traffic_cache: use single regex in url_matcher port [trafficserver]
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall commented on PR #12585:
URL: https://github.com/apache/trafficserver/pull/12585#issuecomment-3423829191
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] traffic_cache: use single regex in url_matcher port [trafficserver]
Posted by "moonchen (via GitHub)" <gi...@apache.org>.
moonchen merged PR #12585:
URL: https://github.com/apache/trafficserver/pull/12585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] traffic_cache: use single regex in url_matcher port [trafficserver]
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall commented on code in PR #12585:
URL: https://github.com/apache/trafficserver/pull/12585#discussion_r2449621407
##########
src/traffic_cache_tool/CacheDefs.h:
##########
@@ -307,7 +307,7 @@ struct url_matcher {
std::cout << "Check your regular expression" << std::endl;
}
- if (!port.compile(R"([0-9]+$)")) {
+ if (!port.compile(R"(^[0-9]+$)")) {
std::cout << "Check your regular expression" << std::endl;
return;
}
Review Comment:
Does the port compile below need to change too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] traffic_cache: use single regex in url_matcher port [trafficserver]
Posted by "moonchen (via GitHub)" <gi...@apache.org>.
moonchen commented on code in PR #12585:
URL: https://github.com/apache/trafficserver/pull/12585#discussion_r2456777106
##########
src/traffic_cache_tool/CacheDefs.h:
##########
@@ -307,7 +307,7 @@ struct url_matcher {
std::cout << "Check your regular expression" << std::endl;
}
- if (!port.compile(R"([0-9]+$)")) {
+ if (!port.compile(R"(^[0-9]+$)")) {
std::cout << "Check your regular expression" << std::endl;
return;
}
Review Comment:
Good catch! Adding it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org