You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/09/05 11:02:56 UTC

[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #5092: [doc] Improve Pulsar Security Extending

Jennifer88huang commented on a change in pull request #5092: [doc] Improve Pulsar Security Extending
URL: https://github.com/apache/pulsar/pull/5092#discussion_r321197740
 
 

 ##########
 File path: site2/docs/security-extending.md
 ##########
 @@ -92,22 +83,18 @@ public interface AuthenticationProvider extends Closeable {
 }
 ```
 
-Example for Broker authentication plugins:
+The follwing is the example for Broker authentication plugins:
 
  * Mutual TLS -- https://github.com/apache/pulsar/blob/master/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderTls.java
  * Athenz -- https://github.com/apache/pulsar/blob/master/pulsar-broker-auth-athenz/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderAthenz.java
 
 ## Authorization
 
-Authorization is the operation that checks whether a particular "role" or "principal" is
-allowed to perform a certain operation.
+Authorization is the operation that checks whether a particular "role" or "principal" has a permission to perform a certain operation.
 
-By default, Pulsar provides an embedded authorization, though it's possible to
-configure a different one through a plugin.
+By default, Pulsar provides an embedded authorization, though configuring a different one through a plugin is also an alternative choice.
 
-To provide a custom provider, one needs to implement the
- `org.apache.pulsar.broker.authorization.AuthorizationProvider` interface, have this class in the
- Pulsar broker classpath and configure it in `conf/broker.conf`:
+To provide a custom provider, you need to implement the `org.apache.pulsar.broker.authorization.AuthorizationProvider` interface, have this class in the Pulsar broker classpath and configure it in `conf/broker.conf`:
 
 Review comment:
   refine "have this class..."

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services