You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Krisztian Szucs (JIRA)" <ji...@apache.org> on 2019/07/05 07:02:00 UTC

[jira] [Resolved] (ARROW-5817) [Python] Use pytest marks for Flight test to avoid silently skipping unit tests due to import failures

     [ https://issues.apache.org/jira/browse/ARROW-5817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Krisztian Szucs resolved ARROW-5817.
------------------------------------
       Resolution: Fixed
    Fix Version/s:     (was: 0.14.0)
                   1.0.0

Issue resolved by pull request 4810
[https://github.com/apache/arrow/pull/4810]

> [Python] Use pytest marks for Flight test to avoid silently skipping unit tests due to import failures
> ------------------------------------------------------------------------------------------------------
>
>                 Key: ARROW-5817
>                 URL: https://issues.apache.org/jira/browse/ARROW-5817
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Python
>            Reporter: Wes McKinney
>            Assignee: Joris Van den Bossche
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.0.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The approach used to determine whether or not Flight has been built will fail silently if the extension is built but there is an ImportError caused by linking or other issues 
> https://github.com/apache/arrow/blob/master/python/pyarrow/tests/test_flight.py#L35
> We should use the same "auto" approach as other optional components (see https://github.com/apache/arrow/blob/master/python/pyarrow/tests/conftest.py#L40) with the option for forced opt-in (so that ImportError does not cause silently skipping) so that {{--flight}} will force the tests to run if we expect them to work



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)