You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/03/31 08:58:52 UTC
[GitHub] [incubator-seatunnel] BenJFan opened a new pull request #1631: [Feature][Connector] update flink elasticsearch sink version
BenJFan opened a new pull request #1631:
URL: https://github.com/apache/incubator-seatunnel/pull/1631
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
Update flink elasticsearch sink version to 7.x
This close #1597
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in you PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/development/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on a change in pull request #1631: [Feature][Connector] update flink elasticsearch sink version
Posted by GitBox <gi...@apache.org>.
BenJFan commented on a change in pull request #1631:
URL: https://github.com/apache/incubator-seatunnel/pull/1631#discussion_r840190694
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -836,28 +841,27 @@ The text of each license is the standard Apache 2.0 license.
(The Apache Software License, Version 2.0) jackson-databind (com.fasterxml.jackson.core:jackson-databind:2.9.2 - http://github.com/FasterXML/jackson)
(The Apache Software License, Version 2.0) jackson-module-scala (com.fasterxml.jackson.module:jackson-module-scala_2.11:2.6.7.1 - http://wiki.fasterxml.com/JacksonModuleScala)
(The Apache Software License, Version 2.0) javax.inject (javax.inject:javax.inject:1 - http://code.google.com/p/atinject/)
- (The Apache Software License, Version 2.0) lang-mustache (org.elasticsearch.plugin:lang-mustache-client:6.3.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) lang-mustache (org.elasticsearch.plugin:lang-mustache-client:7.5.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) mapper-extras (org.elasticsearch.plugin:mapper-extras-client:7.5.1 - https://github.com/elastic/elasticsearch)
(The Apache Software License, Version 2.0) neo4j-connector-apache-spark-2.4.8 (org.neo4j:neo4j-connector-apache-spark_2.11:4.1.0_for_spark_2.4 - https://github.com/neo4j-contrib/neo4j-spark-connector/neo4j-connector-apache-spark_2.12)
(The Apache Software License, Version 2.0) neo4j-connector-apache-spark-common (org.neo4j:neo4j-connector-apache-spark_2.12_common:4.1.0 - https://github.com/neo4j-contrib/neo4j-spark-connector/neo4j-connector-apache-spark_2.12_common)
(The Apache Software License, Version 2.0) okhttp (com.squareup.okhttp3:okhttp:4.9.1 - https://square.github.io/okhttp/)
(The Apache Software License, Version 2.0) okhttp-logging-interceptor (com.squareup.okhttp3:logging-interceptor:4.9.1 - https://square.github.io/okhttp/)
(The Apache Software License, Version 2.0) org.gridkit.lab::jvm-attach-api (org.gridkit.lab:jvm-attach-api:1.5 - http://code.google.com/p/gridkit/jvm-attach-api)
- (The Apache Software License, Version 2.0) parent-join (org.elasticsearch.plugin:parent-join-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) percolator (org.elasticsearch.plugin:percolator-client:6.3.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) parent-join (org.elasticsearch.plugin:parent-join-client:7.5.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) percolator (org.elasticsearch.plugin:percolator-client:7.5.1 - https://github.com/elastic/elasticsearch)
(The Apache Software License, Version 2.0) project ':json-path' (com.jayway.jsonpath:json-path:2.3.0 - https://github.com/jayway/JsonPath)
- (The Apache Software License, Version 2.0) rank-eval (org.elasticsearch.plugin:rank-eval-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) reindex (org.elasticsearch.plugin:reindex-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) rest (org.elasticsearch.client:elasticsearch-rest-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) rest-high-level (org.elasticsearch.client:elasticsearch-rest-high-level-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) secure-sm (org.elasticsearch:elasticsearch-secure-sm:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) server (org.elasticsearch:elasticsearch:6.3.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) rank-eval (org.elasticsearch.plugin:rank-eval-client:7.5.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) reindex (org.elasticsearch.plugin:reindex-client:7.5.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) rest (org.elasticsearch.client:elasticsearch-rest-client:7.5.1 - https://github.com/elastic/elasticsearch)
Review comment:
The reason is `flink-connector-elasticsearch7` use 7.5.1. Can't replace it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on a change in pull request #1631: [Feature][Connector] update flink elasticsearch sink version
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #1631:
URL: https://github.com/apache/incubator-seatunnel/pull/1631#discussion_r840181879
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -836,28 +841,27 @@ The text of each license is the standard Apache 2.0 license.
(The Apache Software License, Version 2.0) jackson-databind (com.fasterxml.jackson.core:jackson-databind:2.9.2 - http://github.com/FasterXML/jackson)
(The Apache Software License, Version 2.0) jackson-module-scala (com.fasterxml.jackson.module:jackson-module-scala_2.11:2.6.7.1 - http://wiki.fasterxml.com/JacksonModuleScala)
(The Apache Software License, Version 2.0) javax.inject (javax.inject:javax.inject:1 - http://code.google.com/p/atinject/)
- (The Apache Software License, Version 2.0) lang-mustache (org.elasticsearch.plugin:lang-mustache-client:6.3.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) lang-mustache (org.elasticsearch.plugin:lang-mustache-client:7.5.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) mapper-extras (org.elasticsearch.plugin:mapper-extras-client:7.5.1 - https://github.com/elastic/elasticsearch)
(The Apache Software License, Version 2.0) neo4j-connector-apache-spark-2.4.8 (org.neo4j:neo4j-connector-apache-spark_2.11:4.1.0_for_spark_2.4 - https://github.com/neo4j-contrib/neo4j-spark-connector/neo4j-connector-apache-spark_2.12)
(The Apache Software License, Version 2.0) neo4j-connector-apache-spark-common (org.neo4j:neo4j-connector-apache-spark_2.12_common:4.1.0 - https://github.com/neo4j-contrib/neo4j-spark-connector/neo4j-connector-apache-spark_2.12_common)
(The Apache Software License, Version 2.0) okhttp (com.squareup.okhttp3:okhttp:4.9.1 - https://square.github.io/okhttp/)
(The Apache Software License, Version 2.0) okhttp-logging-interceptor (com.squareup.okhttp3:logging-interceptor:4.9.1 - https://square.github.io/okhttp/)
(The Apache Software License, Version 2.0) org.gridkit.lab::jvm-attach-api (org.gridkit.lab:jvm-attach-api:1.5 - http://code.google.com/p/gridkit/jvm-attach-api)
- (The Apache Software License, Version 2.0) parent-join (org.elasticsearch.plugin:parent-join-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) percolator (org.elasticsearch.plugin:percolator-client:6.3.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) parent-join (org.elasticsearch.plugin:parent-join-client:7.5.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) percolator (org.elasticsearch.plugin:percolator-client:7.5.1 - https://github.com/elastic/elasticsearch)
(The Apache Software License, Version 2.0) project ':json-path' (com.jayway.jsonpath:json-path:2.3.0 - https://github.com/jayway/JsonPath)
- (The Apache Software License, Version 2.0) rank-eval (org.elasticsearch.plugin:rank-eval-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) reindex (org.elasticsearch.plugin:reindex-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) rest (org.elasticsearch.client:elasticsearch-rest-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) rest-high-level (org.elasticsearch.client:elasticsearch-rest-high-level-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) secure-sm (org.elasticsearch:elasticsearch-secure-sm:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) server (org.elasticsearch:elasticsearch:6.3.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) rank-eval (org.elasticsearch.plugin:rank-eval-client:7.5.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) reindex (org.elasticsearch.plugin:reindex-client:7.5.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) rest (org.elasticsearch.client:elasticsearch-rest-client:7.5.1 - https://github.com/elastic/elasticsearch)
Review comment:
I find there are some [CVE](https://mvnrepository.com/artifact/org.elasticsearch.client/elasticsearch-rest-high-level-client/7.5.1) in `elasticsearch-rest-client:7.5.1`, maybe it's better to set a higher version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1631: [Feature][Connector] update flink elasticsearch sink version
Posted by GitBox <gi...@apache.org>.
BenJFan commented on pull request #1631:
URL: https://github.com/apache/incubator-seatunnel/pull/1631#issuecomment-1085385972
> > > Have you checked, whether the corresponding license or notice has changed, can you list your checklist?
> >
> >
> > I checked elasticsearch series's license, both are Apache license 2
>
> I mean, in addition to this, you also need to check whether the corresponding License file and the corresponding NOTICE have changed.
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1631: [Feature][Connector] update flink elasticsearch sink version
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1631:
URL: https://github.com/apache/incubator-seatunnel/pull/1631#discussion_r840481271
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -836,28 +841,27 @@ The text of each license is the standard Apache 2.0 license.
(The Apache Software License, Version 2.0) jackson-databind (com.fasterxml.jackson.core:jackson-databind:2.9.2 - http://github.com/FasterXML/jackson)
(The Apache Software License, Version 2.0) jackson-module-scala (com.fasterxml.jackson.module:jackson-module-scala_2.11:2.6.7.1 - http://wiki.fasterxml.com/JacksonModuleScala)
(The Apache Software License, Version 2.0) javax.inject (javax.inject:javax.inject:1 - http://code.google.com/p/atinject/)
- (The Apache Software License, Version 2.0) lang-mustache (org.elasticsearch.plugin:lang-mustache-client:6.3.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) lang-mustache (org.elasticsearch.plugin:lang-mustache-client:7.5.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) mapper-extras (org.elasticsearch.plugin:mapper-extras-client:7.5.1 - https://github.com/elastic/elasticsearch)
(The Apache Software License, Version 2.0) neo4j-connector-apache-spark-2.4.8 (org.neo4j:neo4j-connector-apache-spark_2.11:4.1.0_for_spark_2.4 - https://github.com/neo4j-contrib/neo4j-spark-connector/neo4j-connector-apache-spark_2.12)
(The Apache Software License, Version 2.0) neo4j-connector-apache-spark-common (org.neo4j:neo4j-connector-apache-spark_2.12_common:4.1.0 - https://github.com/neo4j-contrib/neo4j-spark-connector/neo4j-connector-apache-spark_2.12_common)
(The Apache Software License, Version 2.0) okhttp (com.squareup.okhttp3:okhttp:4.9.1 - https://square.github.io/okhttp/)
(The Apache Software License, Version 2.0) okhttp-logging-interceptor (com.squareup.okhttp3:logging-interceptor:4.9.1 - https://square.github.io/okhttp/)
(The Apache Software License, Version 2.0) org.gridkit.lab::jvm-attach-api (org.gridkit.lab:jvm-attach-api:1.5 - http://code.google.com/p/gridkit/jvm-attach-api)
- (The Apache Software License, Version 2.0) parent-join (org.elasticsearch.plugin:parent-join-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) percolator (org.elasticsearch.plugin:percolator-client:6.3.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) parent-join (org.elasticsearch.plugin:parent-join-client:7.5.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) percolator (org.elasticsearch.plugin:percolator-client:7.5.1 - https://github.com/elastic/elasticsearch)
(The Apache Software License, Version 2.0) project ':json-path' (com.jayway.jsonpath:json-path:2.3.0 - https://github.com/jayway/JsonPath)
- (The Apache Software License, Version 2.0) rank-eval (org.elasticsearch.plugin:rank-eval-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) reindex (org.elasticsearch.plugin:reindex-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) rest (org.elasticsearch.client:elasticsearch-rest-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) rest-high-level (org.elasticsearch.client:elasticsearch-rest-high-level-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) secure-sm (org.elasticsearch:elasticsearch-secure-sm:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) server (org.elasticsearch:elasticsearch:6.3.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) rank-eval (org.elasticsearch.plugin:rank-eval-client:7.5.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) reindex (org.elasticsearch.plugin:reindex-client:7.5.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) rest (org.elasticsearch.client:elasticsearch-rest-client:7.5.1 - https://github.com/elastic/elasticsearch)
Review comment:
I looked at the corresponding CVE, which is due to log4j-core, but we didn't import it, so we can merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1631: [Feature][Connector] update flink elasticsearch sink version
Posted by GitBox <gi...@apache.org>.
BenJFan commented on pull request #1631:
URL: https://github.com/apache/incubator-seatunnel/pull/1631#issuecomment-1084537558
> Have you checked, whether the corresponding license or notice has changed, can you list your checklist?
I checked elasticsearch series's license, both are Apache license 2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on a change in pull request #1631: [Feature][Connector] update flink elasticsearch sink version
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #1631:
URL: https://github.com/apache/incubator-seatunnel/pull/1631#discussion_r840181879
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -836,28 +841,27 @@ The text of each license is the standard Apache 2.0 license.
(The Apache Software License, Version 2.0) jackson-databind (com.fasterxml.jackson.core:jackson-databind:2.9.2 - http://github.com/FasterXML/jackson)
(The Apache Software License, Version 2.0) jackson-module-scala (com.fasterxml.jackson.module:jackson-module-scala_2.11:2.6.7.1 - http://wiki.fasterxml.com/JacksonModuleScala)
(The Apache Software License, Version 2.0) javax.inject (javax.inject:javax.inject:1 - http://code.google.com/p/atinject/)
- (The Apache Software License, Version 2.0) lang-mustache (org.elasticsearch.plugin:lang-mustache-client:6.3.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) lang-mustache (org.elasticsearch.plugin:lang-mustache-client:7.5.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) mapper-extras (org.elasticsearch.plugin:mapper-extras-client:7.5.1 - https://github.com/elastic/elasticsearch)
(The Apache Software License, Version 2.0) neo4j-connector-apache-spark-2.4.8 (org.neo4j:neo4j-connector-apache-spark_2.11:4.1.0_for_spark_2.4 - https://github.com/neo4j-contrib/neo4j-spark-connector/neo4j-connector-apache-spark_2.12)
(The Apache Software License, Version 2.0) neo4j-connector-apache-spark-common (org.neo4j:neo4j-connector-apache-spark_2.12_common:4.1.0 - https://github.com/neo4j-contrib/neo4j-spark-connector/neo4j-connector-apache-spark_2.12_common)
(The Apache Software License, Version 2.0) okhttp (com.squareup.okhttp3:okhttp:4.9.1 - https://square.github.io/okhttp/)
(The Apache Software License, Version 2.0) okhttp-logging-interceptor (com.squareup.okhttp3:logging-interceptor:4.9.1 - https://square.github.io/okhttp/)
(The Apache Software License, Version 2.0) org.gridkit.lab::jvm-attach-api (org.gridkit.lab:jvm-attach-api:1.5 - http://code.google.com/p/gridkit/jvm-attach-api)
- (The Apache Software License, Version 2.0) parent-join (org.elasticsearch.plugin:parent-join-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) percolator (org.elasticsearch.plugin:percolator-client:6.3.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) parent-join (org.elasticsearch.plugin:parent-join-client:7.5.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) percolator (org.elasticsearch.plugin:percolator-client:7.5.1 - https://github.com/elastic/elasticsearch)
(The Apache Software License, Version 2.0) project ':json-path' (com.jayway.jsonpath:json-path:2.3.0 - https://github.com/jayway/JsonPath)
- (The Apache Software License, Version 2.0) rank-eval (org.elasticsearch.plugin:rank-eval-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) reindex (org.elasticsearch.plugin:reindex-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) rest (org.elasticsearch.client:elasticsearch-rest-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) rest-high-level (org.elasticsearch.client:elasticsearch-rest-high-level-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) secure-sm (org.elasticsearch:elasticsearch-secure-sm:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) server (org.elasticsearch:elasticsearch:6.3.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) rank-eval (org.elasticsearch.plugin:rank-eval-client:7.5.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) reindex (org.elasticsearch.plugin:reindex-client:7.5.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) rest (org.elasticsearch.client:elasticsearch-rest-client:7.5.1 - https://github.com/elastic/elasticsearch)
Review comment:
I find there are some CVE in `elasticsearch-rest-client:7.5.1`, maybe it's better to set a higher version.
https://mvnrepository.com/artifact/org.elasticsearch.client/elasticsearch-rest-high-level-client/7.5.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1631: [Feature][Connector] update flink elasticsearch sink version
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1631:
URL: https://github.com/apache/incubator-seatunnel/pull/1631#issuecomment-1084755377
> > Have you checked, whether the corresponding license or notice has changed, can you list your checklist?
>
> I checked elasticsearch series's license, both are Apache license 2
I mean, in addition to this, you also need to check whether the corresponding License file and the corresponding NOTICE have changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on a change in pull request #1631: [Feature][Connector] update flink elasticsearch sink version
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #1631:
URL: https://github.com/apache/incubator-seatunnel/pull/1631#discussion_r840298834
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -836,28 +841,27 @@ The text of each license is the standard Apache 2.0 license.
(The Apache Software License, Version 2.0) jackson-databind (com.fasterxml.jackson.core:jackson-databind:2.9.2 - http://github.com/FasterXML/jackson)
(The Apache Software License, Version 2.0) jackson-module-scala (com.fasterxml.jackson.module:jackson-module-scala_2.11:2.6.7.1 - http://wiki.fasterxml.com/JacksonModuleScala)
(The Apache Software License, Version 2.0) javax.inject (javax.inject:javax.inject:1 - http://code.google.com/p/atinject/)
- (The Apache Software License, Version 2.0) lang-mustache (org.elasticsearch.plugin:lang-mustache-client:6.3.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) lang-mustache (org.elasticsearch.plugin:lang-mustache-client:7.5.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) mapper-extras (org.elasticsearch.plugin:mapper-extras-client:7.5.1 - https://github.com/elastic/elasticsearch)
(The Apache Software License, Version 2.0) neo4j-connector-apache-spark-2.4.8 (org.neo4j:neo4j-connector-apache-spark_2.11:4.1.0_for_spark_2.4 - https://github.com/neo4j-contrib/neo4j-spark-connector/neo4j-connector-apache-spark_2.12)
(The Apache Software License, Version 2.0) neo4j-connector-apache-spark-common (org.neo4j:neo4j-connector-apache-spark_2.12_common:4.1.0 - https://github.com/neo4j-contrib/neo4j-spark-connector/neo4j-connector-apache-spark_2.12_common)
(The Apache Software License, Version 2.0) okhttp (com.squareup.okhttp3:okhttp:4.9.1 - https://square.github.io/okhttp/)
(The Apache Software License, Version 2.0) okhttp-logging-interceptor (com.squareup.okhttp3:logging-interceptor:4.9.1 - https://square.github.io/okhttp/)
(The Apache Software License, Version 2.0) org.gridkit.lab::jvm-attach-api (org.gridkit.lab:jvm-attach-api:1.5 - http://code.google.com/p/gridkit/jvm-attach-api)
- (The Apache Software License, Version 2.0) parent-join (org.elasticsearch.plugin:parent-join-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) percolator (org.elasticsearch.plugin:percolator-client:6.3.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) parent-join (org.elasticsearch.plugin:parent-join-client:7.5.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) percolator (org.elasticsearch.plugin:percolator-client:7.5.1 - https://github.com/elastic/elasticsearch)
(The Apache Software License, Version 2.0) project ':json-path' (com.jayway.jsonpath:json-path:2.3.0 - https://github.com/jayway/JsonPath)
- (The Apache Software License, Version 2.0) rank-eval (org.elasticsearch.plugin:rank-eval-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) reindex (org.elasticsearch.plugin:reindex-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) rest (org.elasticsearch.client:elasticsearch-rest-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) rest-high-level (org.elasticsearch.client:elasticsearch-rest-high-level-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) secure-sm (org.elasticsearch:elasticsearch-secure-sm:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) server (org.elasticsearch:elasticsearch:6.3.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) rank-eval (org.elasticsearch.plugin:rank-eval-client:7.5.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) reindex (org.elasticsearch.plugin:reindex-client:7.5.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) rest (org.elasticsearch.client:elasticsearch-rest-client:7.5.1 - https://github.com/elastic/elasticsearch)
Review comment:
OK, maybe we can use a high version to override this, but this may cause incompatibility problems, it's better to directly use `flink-connector-elasticsearch7`. This comment can be resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on a change in pull request #1631: [Feature][Connector] update flink elasticsearch sink version
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #1631:
URL: https://github.com/apache/incubator-seatunnel/pull/1631#discussion_r840298834
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -836,28 +841,27 @@ The text of each license is the standard Apache 2.0 license.
(The Apache Software License, Version 2.0) jackson-databind (com.fasterxml.jackson.core:jackson-databind:2.9.2 - http://github.com/FasterXML/jackson)
(The Apache Software License, Version 2.0) jackson-module-scala (com.fasterxml.jackson.module:jackson-module-scala_2.11:2.6.7.1 - http://wiki.fasterxml.com/JacksonModuleScala)
(The Apache Software License, Version 2.0) javax.inject (javax.inject:javax.inject:1 - http://code.google.com/p/atinject/)
- (The Apache Software License, Version 2.0) lang-mustache (org.elasticsearch.plugin:lang-mustache-client:6.3.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) lang-mustache (org.elasticsearch.plugin:lang-mustache-client:7.5.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) mapper-extras (org.elasticsearch.plugin:mapper-extras-client:7.5.1 - https://github.com/elastic/elasticsearch)
(The Apache Software License, Version 2.0) neo4j-connector-apache-spark-2.4.8 (org.neo4j:neo4j-connector-apache-spark_2.11:4.1.0_for_spark_2.4 - https://github.com/neo4j-contrib/neo4j-spark-connector/neo4j-connector-apache-spark_2.12)
(The Apache Software License, Version 2.0) neo4j-connector-apache-spark-common (org.neo4j:neo4j-connector-apache-spark_2.12_common:4.1.0 - https://github.com/neo4j-contrib/neo4j-spark-connector/neo4j-connector-apache-spark_2.12_common)
(The Apache Software License, Version 2.0) okhttp (com.squareup.okhttp3:okhttp:4.9.1 - https://square.github.io/okhttp/)
(The Apache Software License, Version 2.0) okhttp-logging-interceptor (com.squareup.okhttp3:logging-interceptor:4.9.1 - https://square.github.io/okhttp/)
(The Apache Software License, Version 2.0) org.gridkit.lab::jvm-attach-api (org.gridkit.lab:jvm-attach-api:1.5 - http://code.google.com/p/gridkit/jvm-attach-api)
- (The Apache Software License, Version 2.0) parent-join (org.elasticsearch.plugin:parent-join-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) percolator (org.elasticsearch.plugin:percolator-client:6.3.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) parent-join (org.elasticsearch.plugin:parent-join-client:7.5.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) percolator (org.elasticsearch.plugin:percolator-client:7.5.1 - https://github.com/elastic/elasticsearch)
(The Apache Software License, Version 2.0) project ':json-path' (com.jayway.jsonpath:json-path:2.3.0 - https://github.com/jayway/JsonPath)
- (The Apache Software License, Version 2.0) rank-eval (org.elasticsearch.plugin:rank-eval-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) reindex (org.elasticsearch.plugin:reindex-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) rest (org.elasticsearch.client:elasticsearch-rest-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) rest-high-level (org.elasticsearch.client:elasticsearch-rest-high-level-client:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) secure-sm (org.elasticsearch:elasticsearch-secure-sm:6.3.1 - https://github.com/elastic/elasticsearch)
- (The Apache Software License, Version 2.0) server (org.elasticsearch:elasticsearch:6.3.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) rank-eval (org.elasticsearch.plugin:rank-eval-client:7.5.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) reindex (org.elasticsearch.plugin:reindex-client:7.5.1 - https://github.com/elastic/elasticsearch)
+ (The Apache Software License, Version 2.0) rest (org.elasticsearch.client:elasticsearch-rest-client:7.5.1 - https://github.com/elastic/elasticsearch)
Review comment:
OK, maybe we can use a high version to override this, but this may cause incompatibility problems, it's better to directly use `flink-connector-elasticsearch7`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #1631: [Feature][Connector] update flink elasticsearch sink version
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #1631:
URL: https://github.com/apache/incubator-seatunnel/pull/1631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org