You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/05/04 13:48:24 UTC
[GitHub] [couchdb-documentation] bpluly opened a new pull request #531: 511 extending clouseau plugin doc
bpluly opened a new pull request #531:
URL: https://github.com/apache/couchdb-documentation/pull/531
Added a sentence n explicitly setting the classpath in te server parameters when running the service.
## Overview
Issue `[511](https://github.com/apache/couchdb-documentation/issues/511)` asks for elaboration of the Search Plugin documentation page. This pull request amends the current documentation.
## Testing recommendations
Check out the 511-extend-clouseau-pugin-doc branch and run Sphinx to generate the documentation.
`make check` should have no output.
Go to the couchdb-documentation/build/html/install/search.html#install-search and see the result in the browser.
## GitHub issue number
Fixes [511](https://github.com/apache/couchdb-documentation/issues/511)
## Checklist
- [ ] Update [rebar.config.script](https://github.com/apache/couchdb/blob/master/rebar.config.script) with the commit hash once this PR is rebased and merged
<!-- Before opening the PR, consider running `make check` locally for a faster turnaround time -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-documentation] bpluly commented on a change in pull request #531: 511 extending clouseau plugin doc
Posted by GitBox <gi...@apache.org>.
bpluly commented on a change in pull request #531:
URL: https://github.com/apache/couchdb-documentation/pull/531#discussion_r419544934
##########
File path: src/install/search.rst
##########
@@ -33,7 +33,16 @@ Installation of Binary Packages
Binary packages that bundle all the necessary dependencies of the search plugin are
available on `GitHub`_. The files in each release should be unpacked into a directory on
-the Java classpath. The service expects to find a couple of configuration files
+the Java classpath. If you do not have a classpath already set, or you wish to explicitly
+set the classpath location for Clouseau, then add the line::
+
+-classpath '/path/to/clouseau/*'
+
+to the server command below. If clouseau is installed in /opt/clouseau the line would be::
+
+-classpath '/opt/clouseau'
Review comment:
I think I figured out which lines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-documentation] wohali commented on a change in pull request #531: 511 extending clouseau plugin doc
Posted by GitBox <gi...@apache.org>.
wohali commented on a change in pull request #531:
URL: https://github.com/apache/couchdb-documentation/pull/531#discussion_r419469498
##########
File path: src/install/search.rst
##########
@@ -33,7 +33,16 @@ Installation of Binary Packages
Binary packages that bundle all the necessary dependencies of the search plugin are
available on `GitHub`_. The files in each release should be unpacked into a directory on
-the Java classpath. The service expects to find a couple of configuration files
+the Java classpath. If you do not have a classpath already set, or you wish to explicitly
+set the classpath location for Clouseau, then add the line::
+
+-classpath '/path/to/clouseau/*'
Review comment:
Please indent this line by 4 spaces to ensure it is correctly formatted.
##########
File path: src/install/search.rst
##########
@@ -33,7 +33,16 @@ Installation of Binary Packages
Binary packages that bundle all the necessary dependencies of the search plugin are
available on `GitHub`_. The files in each release should be unpacked into a directory on
-the Java classpath. The service expects to find a couple of configuration files
+the Java classpath. If you do not have a classpath already set, or you wish to explicitly
+set the classpath location for Clouseau, then add the line::
+
+-classpath '/path/to/clouseau/*'
+
+to the server command below. If clouseau is installed in /opt/clouseau the line would be::
+
+-classpath '/opt/clouseau'
Review comment:
Please indent this line by 4 spaces to ensure it is correctly formatted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-documentation] bpluly commented on a change in pull request #531: 511 extending clouseau plugin doc
Posted by GitBox <gi...@apache.org>.
bpluly commented on a change in pull request #531:
URL: https://github.com/apache/couchdb-documentation/pull/531#discussion_r419536504
##########
File path: src/install/search.rst
##########
@@ -33,7 +33,16 @@ Installation of Binary Packages
Binary packages that bundle all the necessary dependencies of the search plugin are
available on `GitHub`_. The files in each release should be unpacked into a directory on
-the Java classpath. The service expects to find a couple of configuration files
+the Java classpath. If you do not have a classpath already set, or you wish to explicitly
+set the classpath location for Clouseau, then add the line::
+
+-classpath '/path/to/clouseau/*'
Review comment:
I may have misunderstood as I just accepted the suggestion. Which line should be indented?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-documentation] bpluly commented on a change in pull request #531: 511 extending clouseau plugin doc
Posted by GitBox <gi...@apache.org>.
bpluly commented on a change in pull request #531:
URL: https://github.com/apache/couchdb-documentation/pull/531#discussion_r419546278
##########
File path: src/install/search.rst
##########
@@ -33,7 +33,16 @@ Installation of Binary Packages
Binary packages that bundle all the necessary dependencies of the search plugin are
available on `GitHub`_. The files in each release should be unpacked into a directory on
-the Java classpath. The service expects to find a couple of configuration files
+the Java classpath. If you do not have a classpath already set, or you wish to explicitly
+set the classpath location for Clouseau, then add the line::
+
+-classpath '/path/to/clouseau/*'
Review comment:
All done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-documentation] flimzy commented on a change in pull request #531: 511 extending clouseau plugin doc
Posted by GitBox <gi...@apache.org>.
flimzy commented on a change in pull request #531:
URL: https://github.com/apache/couchdb-documentation/pull/531#discussion_r419487854
##########
File path: src/install/search.rst
##########
@@ -33,7 +33,16 @@ Installation of Binary Packages
Binary packages that bundle all the necessary dependencies of the search plugin are
available on `GitHub`_. The files in each release should be unpacked into a directory on
-the Java classpath. The service expects to find a couple of configuration files
+the Java classpath. If you do not have a classpath already set, or you wish to explicitly
+set the classpath location for Clouseau, then add the line::
+
+-classpath '/path/to/clouseau/*'
+
+to the server command below. If clouseau is installed in /opt/clouseau the line would be::
Review comment:
```suggestion
to the server command below. If clouseau is installed in ``/opt/clouseau`` the line would be::
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-documentation] wohali commented on a change in pull request #531: 511 extending clouseau plugin doc
Posted by GitBox <gi...@apache.org>.
wohali commented on a change in pull request #531:
URL: https://github.com/apache/couchdb-documentation/pull/531#discussion_r419540406
##########
File path: src/install/search.rst
##########
@@ -33,7 +33,16 @@ Installation of Binary Packages
Binary packages that bundle all the necessary dependencies of the search plugin are
available on `GitHub`_. The files in each release should be unpacked into a directory on
-the Java classpath. The service expects to find a couple of configuration files
+the Java classpath. If you do not have a classpath already set, or you wish to explicitly
+set the classpath location for Clouseau, then add the line::
+
+-classpath '/path/to/clouseau/*'
Review comment:
Lines 39 and 43 need to be indented by 4 spaces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-documentation] bpluly commented on pull request #531: 511 extending clouseau plugin doc
Posted by GitBox <gi...@apache.org>.
bpluly commented on pull request #531:
URL: https://github.com/apache/couchdb-documentation/pull/531#issuecomment-623541152
>
>
> Hey @bpluly ! Thanks for the PR. Would you make this small formatting change? Then, we can get this merged.
np, should be done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org