[commons-beanutils] 04/08: Make instance variable final

[gg...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git

commit 17d60ea8406edc247126ccb8ca521d23e6d34eda
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Wed Feb 8 14:12:21 2023 -0500

    Make instance variable final
---
 .../org/apache/commons/beanutils2/locale/BaseLocaleConverter.java     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/apache/commons/beanutils2/locale/BaseLocaleConverter.java b/src/main/java/org/apache/commons/beanutils2/locale/BaseLocaleConverter.java
index 4b4d0e5a..7bdbf45b 100644
--- a/src/main/java/org/apache/commons/beanutils2/locale/BaseLocaleConverter.java
+++ b/src/main/java/org/apache/commons/beanutils2/locale/BaseLocaleConverter.java
@@ -43,7 +43,7 @@ public abstract class BaseLocaleConverter<T> implements LocaleConverter<T> {
     private Object defaultValue;
 
     /** Should we return the default value on conversion errors? */
-    protected boolean useDefault;
+    protected final boolean useDefault;
 
     /** The locale specified to our Constructor, by default - system locale. */
     protected final Locale locale;
@@ -119,8 +119,8 @@ public abstract class BaseLocaleConverter<T> implements LocaleConverter<T> {
             final String pattern, final boolean useDefault, final boolean locPattern) {
         if (useDefault) {
             this.defaultValue = defaultValue;
-            this.useDefault = true;
         }
+        this.useDefault = useDefault;
         this.locale = locale != null ? locale : Locale.getDefault();
         this.pattern = pattern;
         this.localizedPattern = locPattern;