You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "1996fanrui (via GitHub)" <gi...@apache.org> on 2023/04/24 07:35:19 UTC

[GitHub] [flink] 1996fanrui opened a new pull request, #22472: [FLINK-31907][coordination] Remove the unused field inside ExecutionSlotSharingGroupBuilder

1996fanrui opened a new pull request, #22472:
URL: https://github.com/apache/flink/pull/22472

   ## What is the purpose of the change
   
   FLINK-22767 introduced `availableGroupsForJobVertex` to improve the performance during task to slot scheduler.
   
   After FLINK-22767, the `executionSlotSharingGroups`[2] is unused, and it can be removed.
   
   
   [1] https://github.com/apache/flink/blob/f9b3e0b7bc0432001b4a197539a0712b16e0b33b/flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/LocalInputPreferredSlotSharingStrategy.java#L153
   
   [2] https://github.com/apache/flink/blob/f9b3e0b7bc0432001b4a197539a0712b16e0b33b/flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/LocalInputPreferredSlotSharingStrategy.java#L136
   
   
   ## Brief change log
   
   Remove the unused field inside ExecutionSlotSharingGroupBuilder.
   
   
   ## Verifying this change
   
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented?  not documented
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] 1996fanrui commented on pull request #22472: [FLINK-31907][coordination] Remove the unused field inside ExecutionSlotSharingGroupBuilder

Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on PR #22472:
URL: https://github.com/apache/flink/pull/22472#issuecomment-1521094800

   Hi @wanglijie95 , thanks for your review! Merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] 1996fanrui merged pull request #22472: [FLINK-31907][coordination] Remove the unused field inside ExecutionSlotSharingGroupBuilder

Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui merged PR #22472:
URL: https://github.com/apache/flink/pull/22472


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #22472: [FLINK-31907][coordination] Remove the unused field inside ExecutionSlotSharingGroupBuilder

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22472:
URL: https://github.com/apache/flink/pull/22472#issuecomment-1519549973

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d2d248f8d747afbe9d4fd68dbb1144f89d057417",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d2d248f8d747afbe9d4fd68dbb1144f89d057417",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d2d248f8d747afbe9d4fd68dbb1144f89d057417 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] 1996fanrui commented on pull request #22472: [FLINK-31907][coordination] Remove the unused field inside ExecutionSlotSharingGroupBuilder

Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on PR #22472:
URL: https://github.com/apache/flink/pull/22472#issuecomment-1519903816

   Hi @zhuzhurk  and @wanglijie95 , would you mind help review this PR? thanks~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org