You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Marcus <ma...@wtnet.de> on 2016/12/21 18:29:56 UTC

Re: svn commit: r1775507 - /openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx

I wanted to suggest exactly after seeing your previous commit.

So, thanks for being faster than me. ;-)

Marcus



Am 12/21/2016 05:58 PM, schrieb damjan@apache.org:
> Author: damjan
> Date: Wed Dec 21 16:58:47 2016
> New Revision: 1775507
>
> URL: http://svn.apache.org/viewvc?rev=1775507&view=rev
> Log:
> Use "OpenOffice" instead of "soffice" as our KDE appName.
>
> Patch by: pfg
> Reviewed by: me
>
>
> Modified:
>      openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx
>
> Modified: openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx
> URL: http://svn.apache.org/viewvc/openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx?rev=1775507&r1=1775506&r2=1775507&view=diff
> ==============================================================================
> --- openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx (original)
> +++ openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx Wed Dec 21 16:58:47 2016
> @@ -74,7 +74,7 @@ void KDEXLib::Init()
>   	pInputMethod->SetLocale();
>   	XrmInitialize();
>
> -	KAboutData *kAboutData = new KAboutData("soffice",
> +	KAboutData *kAboutData = new KAboutData("OpenOffice",
>   			"kdelibs4",
>   			ki18n( "Apache OpenOffice" ),
>   			"3.4.0",

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Re: svn commit: r1775507 - /openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx

Posted by Andrea Pescetti <pe...@apache.org>.
Pedro wrote:
> Would it be possible to do the same for the Windows OS?

No. Actually, it was discussed years ago (in other circumstances: the 
discussion at the time was that the "soffice" executable belonged to 
OpenOffice and it was inappropriate for different software to use it) 
and the result was that using a different name than "soffice" would 
break compatibility with supposedly many applications that expected to 
call "soffice" to get OpenOffice (or, at this point, an alternative 
application).

I understand that Damjan's patch does not change the name of the 
executable but simply a launcher detail. In this case it wouldn't be an 
issue.

Regards,
   Andrea.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Re: svn commit: r1775507 - /openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx

Posted by Matthias Seidel <ma...@hamburg.de>.
Hi Pedro,

Just my thought!

+1 if there a no technical reasons against it.

regards, Matthias


Am 21.12.2016 um 20:43 schrieb Pedro:
> Would it be possible to do the same for the Windows OS?
>
> Now that the 8.3 file name limitation is gone (I think...) this would
> be a way to solve incompatibilities on systems also running
> LibreOffice...
>
> Just a thought ;)
>
>
> On 21/12/2016 18:29, Marcus wrote:
>> I wanted to suggest exactly after seeing your previous commit.
>>
>> So, thanks for being faster than me. ;-)
>>
>> Marcus
>>
>>
>>
>> Am 12/21/2016 05:58 PM, schrieb damjan@apache.org:
>>> Author: damjan
>>> Date: Wed Dec 21 16:58:47 2016
>>> New Revision: 1775507
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1775507&view=rev
>>> Log:
>>> Use "OpenOffice" instead of "soffice" as our KDE appName.
>>>
>>> Patch by: pfg
>>> Reviewed by: me
>>>
>>>
>>> Modified:
>>>      openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx
>>>
>>> Modified: openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx
>>> URL:
>>> http://svn.apache.org/viewvc/openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx?rev=1775507&r1=1775506&r2=1775507&view=diff
>>> ==============================================================================
>>>
>>> --- openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx (original)
>>> +++ openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx Wed Dec 21
>>> 16:58:47 2016
>>> @@ -74,7 +74,7 @@ void KDEXLib::Init()
>>>       pInputMethod->SetLocale();
>>>       XrmInitialize();
>>>
>>> -    KAboutData *kAboutData = new KAboutData("soffice",
>>> +    KAboutData *kAboutData = new KAboutData("OpenOffice",
>>>               "kdelibs4",
>>>               ki18n( "Apache OpenOffice" ),
>>>               "3.4.0",
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
>> For additional commands, e-mail: dev-help@openoffice.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
> For additional commands, e-mail: dev-help@openoffice.apache.org
>



Re: svn commit: r1775507 - /openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx

Posted by Pedro <pe...@openmailbox.org>.
Would it be possible to do the same for the Windows OS?

Now that the 8.3 file name limitation is gone (I think...) this would be 
a way to solve incompatibilities on systems also running LibreOffice...

Just a thought ;)


On 21/12/2016 18:29, Marcus wrote:
> I wanted to suggest exactly after seeing your previous commit.
>
> So, thanks for being faster than me. ;-)
>
> Marcus
>
>
>
> Am 12/21/2016 05:58 PM, schrieb damjan@apache.org:
>> Author: damjan
>> Date: Wed Dec 21 16:58:47 2016
>> New Revision: 1775507
>>
>> URL: http://svn.apache.org/viewvc?rev=1775507&view=rev
>> Log:
>> Use "OpenOffice" instead of "soffice" as our KDE appName.
>>
>> Patch by: pfg
>> Reviewed by: me
>>
>>
>> Modified:
>>      openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx
>>
>> Modified: openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx
>> URL: 
>> http://svn.apache.org/viewvc/openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx?rev=1775507&r1=1775506&r2=1775507&view=diff
>> ============================================================================== 
>>
>> --- openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx (original)
>> +++ openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx Wed Dec 21 
>> 16:58:47 2016
>> @@ -74,7 +74,7 @@ void KDEXLib::Init()
>>       pInputMethod->SetLocale();
>>       XrmInitialize();
>>
>> -    KAboutData *kAboutData = new KAboutData("soffice",
>> +    KAboutData *kAboutData = new KAboutData("OpenOffice",
>>               "kdelibs4",
>>               ki18n( "Apache OpenOffice" ),
>>               "3.4.0",
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
> For additional commands, e-mail: dev-help@openoffice.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Re: svn commit: r1775507 - /openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx

Posted by Marcus <ma...@wtnet.de>.
Am 12/21/2016 07:34 PM, schrieb Damjan Jovanovic:
> Pleasure ;-)
>
> You use KDE too?

unfortunately, not. My last time was with SuSE 6 or 7.
Since then I'm working on ReadHat-based systems and Gnome.

Marcus



> On Wed, Dec 21, 2016 at 8:29 PM, Marcus<ma...@wtnet.de>  wrote:
>> I wanted to suggest exactly after seeing your previous commit.
>>
>> So, thanks for being faster than me. ;-)
>>
>> Marcus
>>
>>
>>
>> Am 12/21/2016 05:58 PM, schrieb damjan@apache.org:
>>>
>>> Author: damjan
>>> Date: Wed Dec 21 16:58:47 2016
>>> New Revision: 1775507
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1775507&view=rev
>>> Log:
>>> Use "OpenOffice" instead of "soffice" as our KDE appName.
>>>
>>> Patch by: pfg
>>> Reviewed by: me
>>>
>>>
>>> Modified:
>>>       openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx
>>>
>>> Modified: openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx
>>> URL:
>>> http://svn.apache.org/viewvc/openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx?rev=1775507&r1=1775506&r2=1775507&view=diff
>>>
>>> ==============================================================================
>>> --- openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx (original)
>>> +++ openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx Wed Dec 21 16:58:47
>>> 2016
>>> @@ -74,7 +74,7 @@ void KDEXLib::Init()
>>>          pInputMethod->SetLocale();
>>>          XrmInitialize();
>>>
>>> -       KAboutData *kAboutData = new KAboutData("soffice",
>>> +       KAboutData *kAboutData = new KAboutData("OpenOffice",
>>>                          "kdelibs4",
>>>                          ki18n( "Apache OpenOffice" ),
>>>                          "3.4.0",

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Re: svn commit: r1775507 - /openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx

Posted by Damjan Jovanovic <da...@apache.org>.
Pleasure ;-)

You use KDE too?

On Wed, Dec 21, 2016 at 8:29 PM, Marcus <ma...@wtnet.de> wrote:
> I wanted to suggest exactly after seeing your previous commit.
>
> So, thanks for being faster than me. ;-)
>
> Marcus
>
>
>
> Am 12/21/2016 05:58 PM, schrieb damjan@apache.org:
>>
>> Author: damjan
>> Date: Wed Dec 21 16:58:47 2016
>> New Revision: 1775507
>>
>> URL: http://svn.apache.org/viewvc?rev=1775507&view=rev
>> Log:
>> Use "OpenOffice" instead of "soffice" as our KDE appName.
>>
>> Patch by: pfg
>> Reviewed by: me
>>
>>
>> Modified:
>>      openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx
>>
>> Modified: openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx
>> URL:
>> http://svn.apache.org/viewvc/openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx?rev=1775507&r1=1775506&r2=1775507&view=diff
>>
>> ==============================================================================
>> --- openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx (original)
>> +++ openoffice/trunk/main/vcl/unx/kde4/KDEXLib.cxx Wed Dec 21 16:58:47
>> 2016
>> @@ -74,7 +74,7 @@ void KDEXLib::Init()
>>         pInputMethod->SetLocale();
>>         XrmInitialize();
>>
>> -       KAboutData *kAboutData = new KAboutData("soffice",
>> +       KAboutData *kAboutData = new KAboutData("OpenOffice",
>>                         "kdelibs4",
>>                         ki18n( "Apache OpenOffice" ),
>>                         "3.4.0",
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
> For additional commands, e-mail: dev-help@openoffice.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org