You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by vm...@apache.org on 2003/06/04 21:23:03 UTC
cvs commit: maven/src/plugins-build/checkstyle plugin.jelly
vmassol 2003/06/04 12:23:03
Modified: src/plugins-build/checkstyle plugin.jelly
Log:
Fixed "exclude" bug. Thanks to Thomas Diesler.
Revision Changes Path
1.7 +1 -1 maven/src/plugins-build/checkstyle/plugin.jelly
Index: plugin.jelly
===================================================================
RCS file: /home/cvs/maven/src/plugins-build/checkstyle/plugin.jelly,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- plugin.jelly 30 May 2003 13:13:25 -0000 1.6
+++ plugin.jelly 4 Jun 2003 19:23:03 -0000 1.7
@@ -130,7 +130,7 @@
<ant:fileset dir="${pom.build.sourceDirectory}">
<ant:include name="${maven.checkstyle.includes}"/>
- <ant:include name="${maven.checkstyle.excludes}"/>
+ <ant:exclude name="${maven.checkstyle.excludes}"/>
</ant:fileset>
<ant:formatter type="xml"
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: cvs commit: maven/src/plugins-build/checkstyle plugin.jelly
Posted by Vincent Massol <vm...@pivolis.com>.
Fixed for Cactus and Checkstyle.
Thanks
-Vincent
> -----Original Message-----
> From: Florin Vancea [mailto:fvancea@maxiq.ro]
> Sent: 05 June 2003 07:24
> To: Maven Developers List
> Subject: Re: cvs commit: maven/src/plugins-build/checkstyle
plugin.jelly
>
> P.S.: I did a quick search for 'include name="${' in the sources and I
> suspect the same issue also appears in the following plugins:
>
> cactus, ejb, jalopy, war,
>
> eventually with different potential of getting transformed into a
> significant bug. Usually these properties are left untouched by the
> "end-users" and that's why this did not show up until now.
>
> Florin.
>
>
> ----- Original Message -----
> From: "Florin Vancea" <fv...@maxiq.ro>
> To: "Maven Developers List" <de...@maven.apache.org>
> Sent: Thursday, June 05, 2003 8:09 AM
> Subject: Re: cvs commit: maven/src/plugins-build/checkstyle
plugin.jelly
>
>
> > Vincent, I think you missed what Thomas really meant, and catched
> another
> > bug (actually a typo).
> >
> > The <ant:include ...> element may have in the name attribute
_just_one_
> > pattern, therefore if the property contains several patterns, as the
> > property name suggests, then something will go wrong.
> >
> > Thomas suggested to use instead the attributes of the <fileset..>
> element
> > (i.e. "includes" and "excludes"), which support comma or space
delimited
> > pattern sets.
> >
> > Florin
> >
> > ----- Original Message -----
> > From: <vm...@apache.org>
> > To: <ma...@apache.org>
> > Sent: Wednesday, June 04, 2003 10:23 PM
> > Subject: cvs commit: maven/src/plugins-build/checkstyle plugin.jelly
> >
> >
> > > vmassol 2003/06/04 12:23:03
> > >
> > > Modified: src/plugins-build/checkstyle plugin.jelly
> > > Log:
> > > Fixed "exclude" bug. Thanks to Thomas Diesler.
> > >
> > > Revision Changes Path
> > > 1.7 +1 -1
maven/src/plugins-build/checkstyle/plugin.jelly
> > >
> > > Index: plugin.jelly
> > >
===================================================================
> > > RCS file: /home/cvs/maven/src/plugins-
> build/checkstyle/plugin.jelly,v
> > > retrieving revision 1.6
> > > retrieving revision 1.7
> > > diff -u -r1.6 -r1.7
> > > --- plugin.jelly 30 May 2003 13:13:25 -0000 1.6
> > > +++ plugin.jelly 4 Jun 2003 19:23:03 -0000 1.7
> > > @@ -130,7 +130,7 @@
> > >
> > > <ant:fileset dir="${pom.build.sourceDirectory}">
> > > <ant:include name="${maven.checkstyle.includes}"/>
> > > - <ant:include name="${maven.checkstyle.excludes}"/>
> > > + <ant:exclude name="${maven.checkstyle.excludes}"/>
> > > </ant:fileset>
> > >
> > > <ant:formatter type="xml"
> > >
> > >
> > >
> > >
> > >
---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > For additional commands, e-mail: dev-help@maven.apache.org
> > >
> > >
> >
> >
> >
> >
---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: cvs commit: maven/src/plugins-build/checkstyle plugin.jelly
Posted by Florin Vancea <fv...@maxiq.ro>.
P.S.: I did a quick search for 'include name="${' in the sources and I
suspect the same issue also appears in the following plugins:
cactus, ejb, jalopy, war,
eventually with different potential of getting transformed into a
significant bug. Usually these properties are left untouched by the
"end-users" and that's why this did not show up until now.
Florin.
----- Original Message -----
From: "Florin Vancea" <fv...@maxiq.ro>
To: "Maven Developers List" <de...@maven.apache.org>
Sent: Thursday, June 05, 2003 8:09 AM
Subject: Re: cvs commit: maven/src/plugins-build/checkstyle plugin.jelly
> Vincent, I think you missed what Thomas really meant, and catched another
> bug (actually a typo).
>
> The <ant:include ...> element may have in the name attribute _just_one_
> pattern, therefore if the property contains several patterns, as the
> property name suggests, then something will go wrong.
>
> Thomas suggested to use instead the attributes of the <fileset..> element
> (i.e. "includes" and "excludes"), which support comma or space delimited
> pattern sets.
>
> Florin
>
> ----- Original Message -----
> From: <vm...@apache.org>
> To: <ma...@apache.org>
> Sent: Wednesday, June 04, 2003 10:23 PM
> Subject: cvs commit: maven/src/plugins-build/checkstyle plugin.jelly
>
>
> > vmassol 2003/06/04 12:23:03
> >
> > Modified: src/plugins-build/checkstyle plugin.jelly
> > Log:
> > Fixed "exclude" bug. Thanks to Thomas Diesler.
> >
> > Revision Changes Path
> > 1.7 +1 -1 maven/src/plugins-build/checkstyle/plugin.jelly
> >
> > Index: plugin.jelly
> > ===================================================================
> > RCS file: /home/cvs/maven/src/plugins-build/checkstyle/plugin.jelly,v
> > retrieving revision 1.6
> > retrieving revision 1.7
> > diff -u -r1.6 -r1.7
> > --- plugin.jelly 30 May 2003 13:13:25 -0000 1.6
> > +++ plugin.jelly 4 Jun 2003 19:23:03 -0000 1.7
> > @@ -130,7 +130,7 @@
> >
> > <ant:fileset dir="${pom.build.sourceDirectory}">
> > <ant:include name="${maven.checkstyle.includes}"/>
> > - <ant:include name="${maven.checkstyle.excludes}"/>
> > + <ant:exclude name="${maven.checkstyle.excludes}"/>
> > </ant:fileset>
> >
> > <ant:formatter type="xml"
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: cvs commit: maven/src/plugins-build/checkstyle plugin.jelly
Posted by Florin Vancea <fv...@maxiq.ro>.
I myself have bumped into this some days ago trying to integrate the webtest
plugin (hosted on SF) into my Maven. Something was not working as I'd
expected and I pulled out the Ant docos. Surprise-surprise, .... :)
Yours,
Florin
----- Original Message -----
From: "Vincent Massol" <vm...@pivolis.com>
To: "'Maven Developers List'" <de...@maven.apache.org>
Sent: Thursday, June 05, 2003 8:42 AM
Subject: RE: cvs commit: maven/src/plugins-build/checkstyle plugin.jelly
> Ah right, I understand now. I have learnt something today! :-) (I hadn't
> realized this).
>
> Thanks
> -Vincent
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: cvs commit: maven/src/plugins-build/checkstyle plugin.jelly
Posted by Vincent Massol <vm...@pivolis.com>.
Ah right, I understand now. I have learnt something today! :-) (I hadn't
realized this).
Thanks
-Vincent
> -----Original Message-----
> From: Florin Vancea [mailto:fvancea@maxiq.ro]
> Sent: 05 June 2003 07:10
> To: Maven Developers List
> Subject: Re: cvs commit: maven/src/plugins-build/checkstyle
plugin.jelly
>
> Vincent, I think you missed what Thomas really meant, and catched
another
> bug (actually a typo).
>
> The <ant:include ...> element may have in the name attribute
_just_one_
> pattern, therefore if the property contains several patterns, as the
> property name suggests, then something will go wrong.
>
> Thomas suggested to use instead the attributes of the <fileset..>
element
> (i.e. "includes" and "excludes"), which support comma or space
delimited
> pattern sets.
>
> Florin
>
> ----- Original Message -----
> From: <vm...@apache.org>
> To: <ma...@apache.org>
> Sent: Wednesday, June 04, 2003 10:23 PM
> Subject: cvs commit: maven/src/plugins-build/checkstyle plugin.jelly
>
>
> > vmassol 2003/06/04 12:23:03
> >
> > Modified: src/plugins-build/checkstyle plugin.jelly
> > Log:
> > Fixed "exclude" bug. Thanks to Thomas Diesler.
> >
> > Revision Changes Path
> > 1.7 +1 -1
maven/src/plugins-build/checkstyle/plugin.jelly
> >
> > Index: plugin.jelly
> >
===================================================================
> > RCS file:
/home/cvs/maven/src/plugins-build/checkstyle/plugin.jelly,v
> > retrieving revision 1.6
> > retrieving revision 1.7
> > diff -u -r1.6 -r1.7
> > --- plugin.jelly 30 May 2003 13:13:25 -0000 1.6
> > +++ plugin.jelly 4 Jun 2003 19:23:03 -0000 1.7
> > @@ -130,7 +130,7 @@
> >
> > <ant:fileset dir="${pom.build.sourceDirectory}">
> > <ant:include name="${maven.checkstyle.includes}"/>
> > - <ant:include name="${maven.checkstyle.excludes}"/>
> > + <ant:exclude name="${maven.checkstyle.excludes}"/>
> > </ant:fileset>
> >
> > <ant:formatter type="xml"
> >
> >
> >
> >
> >
---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: cvs commit: maven/src/plugins-build/checkstyle plugin.jelly
Posted by Florin Vancea <fv...@maxiq.ro>.
Vincent, I think you missed what Thomas really meant, and catched another
bug (actually a typo).
The <ant:include ...> element may have in the name attribute _just_one_
pattern, therefore if the property contains several patterns, as the
property name suggests, then something will go wrong.
Thomas suggested to use instead the attributes of the <fileset..> element
(i.e. "includes" and "excludes"), which support comma or space delimited
pattern sets.
Florin
----- Original Message -----
From: <vm...@apache.org>
To: <ma...@apache.org>
Sent: Wednesday, June 04, 2003 10:23 PM
Subject: cvs commit: maven/src/plugins-build/checkstyle plugin.jelly
> vmassol 2003/06/04 12:23:03
>
> Modified: src/plugins-build/checkstyle plugin.jelly
> Log:
> Fixed "exclude" bug. Thanks to Thomas Diesler.
>
> Revision Changes Path
> 1.7 +1 -1 maven/src/plugins-build/checkstyle/plugin.jelly
>
> Index: plugin.jelly
> ===================================================================
> RCS file: /home/cvs/maven/src/plugins-build/checkstyle/plugin.jelly,v
> retrieving revision 1.6
> retrieving revision 1.7
> diff -u -r1.6 -r1.7
> --- plugin.jelly 30 May 2003 13:13:25 -0000 1.6
> +++ plugin.jelly 4 Jun 2003 19:23:03 -0000 1.7
> @@ -130,7 +130,7 @@
>
> <ant:fileset dir="${pom.build.sourceDirectory}">
> <ant:include name="${maven.checkstyle.includes}"/>
> - <ant:include name="${maven.checkstyle.excludes}"/>
> + <ant:exclude name="${maven.checkstyle.excludes}"/>
> </ant:fileset>
>
> <ant:formatter type="xml"
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org