You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2020/07/22 13:18:15 UTC
[GitHub] [incubator-datasketches-cpp] gaborkaszab opened a new pull request #166: Issue-165: Remove c-style const casts from kll/ and common directories
gaborkaszab opened a new pull request #166:
URL: https://github.com/apache/incubator-datasketches-cpp/pull/166
The motivation behind this change is that I recently started integrating
DataSketches KLL into Apache Impala and our Clang tidy build showed some issues
where c-style casts were used to remove const-ness of variables.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [incubator-datasketches-cpp] AlexanderSaydakov merged pull request #166: Issue-165: Remove c-style const casts from kll/ and common directories
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov merged pull request #166:
URL: https://github.com/apache/incubator-datasketches-cpp/pull/166
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [incubator-datasketches-cpp] jmalkin commented on pull request #166: Issue-165: Remove c-style const casts from kll/ and common directories
Posted by GitBox <gi...@apache.org>.
jmalkin commented on pull request #166:
URL: https://github.com/apache/incubator-datasketches-cpp/pull/166#issuecomment-662591686
Github actions seem to be having trouble with the Mac queue. Checked it locally and it was fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org