[GitHub] [iceberg] szehon-ho commented on a diff in pull request #6175: Hive: Add UGI to the key in CachedClientPool

[GitBox <gi...@apache.org>]

szehon-ho commented on code in PR #6175:
URL: https://github.com/apache/iceberg/pull/6175#discussion_r1022551766


##########
hive-metastore/src/main/java/org/apache/iceberg/hive/CachedClientPool.java:
##########
@@ -87,4 +91,23 @@ public <R> R run(Action<R, IMetaStoreClient, TException> action, boolean retry)
       throws TException, InterruptedException {
     return clientPool().run(action, retry);
   }
+
+  @VisibleForTesting
+  @Value.Immutable
+  abstract static class Key {

Review Comment:
   This is great, this is actually a common issue, a lot of values are not in the cache key but should be..
   
   See this issue as well:  https://github.com/apache/iceberg/pull/5378  for default Hive catalog, I guess we can put catalog in this as well then.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org