You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by jh...@apache.org on 2017/08/11 01:50:25 UTC

[28/50] calcite-avatica-go git commit: Remove go 1.8 build tag for compatibility structs and constants

Remove go 1.8 build tag for compatibility structs and constants


Project: http://git-wip-us.apache.org/repos/asf/calcite-avatica-go/repo
Commit: http://git-wip-us.apache.org/repos/asf/calcite-avatica-go/commit/36cfe221
Tree: http://git-wip-us.apache.org/repos/asf/calcite-avatica-go/tree/36cfe221
Diff: http://git-wip-us.apache.org/repos/asf/calcite-avatica-go/diff/36cfe221

Branch: refs/heads/master
Commit: 36cfe2218a5a7f833175c45635834faa9978b93d
Parents: dc21f11
Author: Francis Chuang <fr...@boostport.com>
Authored: Fri Mar 10 16:44:03 2017 +1100
Committer: Julian Hyde <jh...@apache.org>
Committed: Thu Aug 10 18:47:11 2017 -0700

----------------------------------------------------------------------
 compat_go18.go | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/calcite-avatica-go/blob/36cfe221/compat_go18.go
----------------------------------------------------------------------
diff --git a/compat_go18.go b/compat_go18.go
index f57cc11..6c60866 100644
--- a/compat_go18.go
+++ b/compat_go18.go
@@ -1,5 +1,3 @@
-// +build go1.8
-
 package avatica
 
 import (
@@ -26,14 +24,14 @@ func driverValueToNamedValue(values []driver.Value) []namedValue {
 	return list
 }
 
-func driverNamedValueToNamedValue(values []driver.NamedValue) ([]namedValue,error ) {
+func driverNamedValueToNamedValue(values []driver.NamedValue) ([]namedValue, error) {
 	list := make([]namedValue, len(values))
 
 	for i, nv := range values {
 		list[i] = namedValue(nv)
 
-		if nv.Name != ""{
-			return list,fmt.Errorf("named paramters are not supported: %s given", nv.Name)
+		if nv.Name != "" {
+			return list, fmt.Errorf("named paramters are not supported: %s given", nv.Name)
 		}
 	}