Re: [PR] [SPARK-45680][CONNECT] Release session [spark]

["heyihong (via GitHub)" <gi...@apache.org>]

heyihong commented on code in PR #43546:
URL: https://github.com/apache/spark/pull/43546#discussion_r1376290191


##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -667,6 +667,7 @@ class SparkSession private[sql] (
    * @since 3.4.0
    */
   override def close(): Unit = {
+    client.releaseSession()

Review Comment:
   Should releaseSession be called inside `client.shutdown()`?



##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -667,6 +667,7 @@ class SparkSession private[sql] (
    * @since 3.4.0
    */
   override def close(): Unit = {
+    client.releaseSession()

Review Comment:
   Should `client.releaseSession()` be called inside `client.shutdown()`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org