You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "I3eka (via GitHub)" <gi...@apache.org> on 2026/10/26 04:17:41 UTC

[PR] fix(ai): preserve valid bounded tool output in history [superset]

I3eka opened a new pull request, #45727:
URL: https://github.com/apache/superset/pull/45727

   ## Status
   
   **Draft / ON HOLD pending SIP-224:** parent proposal #42805 and discussion #42806. This Native AI follow-up is not ready to merge before the parent proposal is accepted. The branch includes the prerequisite tool-display work in #43237; the focused change is `d7f603aeef`.
   
   ## Problem and change
   
   Persisted tool output was cut at 2,000 characters, often leaving incomplete JSON without indicating that the stored history differed from the result shown to the model. Bound structured output with the existing JSON-aware byte limiter, retain a separate `output_truncated` flag, and label history clipping separately in the tool details. The model-facing result and its own truncation flag remain independent.
   
   ## Validation
   
   - Two regression tests failed before the fix; 69 runtime/orchestrator/display tests pass after it.
   - The frontend regression verifies parsing and the distinct history-clipping label.
   - Pre-commit passes, including backend and frontend type checks.
   - No deployment or live model/database calls.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(ai): preserve valid bounded tool output in history [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45727:
URL: https://github.com/apache/superset/pull/45727#issuecomment-6461099799

   ### ⚠️ Possible DB migration conflict
   
   @I3eka the base branch `master` picked up a new database migration under `superset/migrations/` after this PR was opened, and this PR adds or modifies migration files too. Alembic migrations form a single linear chain, so if both branch off the same parent revision, merging this PR as-is could leave the migration history with two heads instead of one, which makes `superset db upgrade` fail with `Multiple head revisions are present`.
   
   To check and, if needed, fix this:
   
   1. Rebase this branch onto the latest `master`.
   2. Run `superset db heads`. If it lists more than one revision, you have a conflict.
   3. In your new migration's script, update `down_revision` (and the `Revises` comment) to point at the other head instead, so the chain has a single head again.
   
   See [Merging DB Migrations](https://superset.apache.org/docs/contributing/development#merging-db-migrations) in the contributing guide for a worked example.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(ai): preserve valid bounded tool output in history [superset]

Posted by "I3eka (via GitHub)" <gi...@apache.org>.
I3eka commented on PR #45727:
URL: https://github.com/apache/superset/pull/45727#issuecomment-6435642899

   Reviewed the current discussion and the focused implementation, and merged Apache master `037abb7d0b433c1274ab55f95e5613310f132462` without rewriting the branch. Published head: `7791b483c8043151f9e642cb5aff681c2235d2c9`. There are no inline review threads or outstanding substantive reviewer findings on this PR in this audit.
   
   Refresh the translation template for the history-clipping label and remove twelve inherited obsolete entries. The translation drift reproduces before regeneration and the source/template checks pass afterward.
   
   - 727 tests passed: the full AI unit suite and the single-migration-head check.
   - 106 AI frontend tests passed.
   - All applicable pre-commit hooks passed for the 118 files in this PR delta.
   - The translation template matches a fresh extraction from the exact committed tree.
   
   This follow-up changes only messages.pot. Backend/frontend results are retained from `23a181f58c5f08691b0e9861b1075d4dad24f3cd` with identical source/tests; 20 translation checks and the POT hooks passed after regeneration. Existing formatting and translation flags are preserved.
   
   Includes prerequisite tool-display work in #43237. Runtime, history parsing and rendered label regressions are deterministic local tests, not a live model/warehouse check.
   
   Updated the description to match this head and its validation. This stays **Draft / ON HOLD** behind #42805 and SIP #42806. No deployment, live database migration or external provider call was performed; GitHub CI is separate from these local checks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(ai): preserve valid bounded tool output in history [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #45727:
URL: https://github.com/apache/superset/pull/45727#issuecomment-6408139027

   ### <span aria-hidden="true">βœ…</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">πŸ”¨</span> Latest commit | d7f603aeef740f9931d787db83b336b77f4192b4 |
   |<span aria-hidden="true">πŸ”</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6aded465ab7b7df548a74999 |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-45727--superset-docs-preview.netlify.app](https://deploy-preview-45727--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">πŸ“±</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTQ1NzI3LS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.qJF0OHEN3YAjGJ8vH7Sn-HZGfIYeNo6rgwKiSh_auGI)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   |<span aria-hidden="true">πŸ€–</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcoxDoAgDADAv3SWuICIP_AZxUIgQUuwJhrj32W74V6ojfcqsAAM4BseW-qO-R4xK2EuKuVTuD2KL6mX9EWhFn5W6m9CCqQng956S9HoGa12zsH3Aw) |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-45727--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(ai): preserve valid bounded tool output in history [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45727:
URL: https://github.com/apache/superset/pull/45727#issuecomment-6455914035

   ### ⚠️ Possible DB migration conflict
   
   @I3eka the base branch `master` picked up a new database migration under `superset/migrations/` after this PR was opened, and this PR adds or modifies migration files too. Alembic migrations form a single linear chain, so if both branch off the same parent revision, merging this PR as-is could leave the migration history with two heads instead of one, which makes `superset db upgrade` fail with `Multiple head revisions are present`.
   
   To check and, if needed, fix this:
   
   1. Rebase this branch onto the latest `master`.
   2. Run `superset db heads`. If it lists more than one revision, you have a conflict.
   3. In your new migration's script, update `down_revision` (and the `Revises` comment) to point at the other head instead, so the chain has a single head again.
   
   See [Merging DB Migrations](https://superset.apache.org/docs/contributing/development#merging-db-migrations) in the contributing guide for a worked example.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(ai): preserve valid bounded tool output in history [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #45727:
URL: https://github.com/apache/superset/pull/45727#issuecomment-6408135544

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/45727?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `9.95522%` with `2614 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 55.74%. Comparing base ([`0ccb586`](https://app.codecov.io/gh/apache/superset/commit/0ccb586540a50b780936789510f6503d37eeafc9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d7f603a`](https://app.codecov.io/gh/apache/superset/commit/d7f603aeef740f9931d787db83b336b77f4192b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 3 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/45727?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [superset/ai/orchestrator.py](https://app.codecov.io/gh/apache/superset/pull/45727?src=pr&el=tree&filepath=superset%2Fai%2Forchestrator.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYWkvb3JjaGVzdHJhdG9yLnB5) | 0.00% | [236 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/45727?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [superset/ai/llm/openai\_compatible.py](https://app.codecov.io/gh/apache/superset/pull/45727?src=pr&el=tree&filepath=superset%2Fai%2Fllm%2Fopenai_compatible.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYWkvbGxtL29wZW5haV9jb21wYXRpYmxlLnB5) | 0.00% | [219 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/45727?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [superset/ai/api.py](https://app.codecov.io/gh/apache/superset/pull/45727?src=pr&el=tree&filepath=superset%2Fai%2Fapi.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYWkvYXBpLnB5) | 33.93% | [218 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/45727?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [superset/ai/llm/anthropic.py](https://app.codecov.io/gh/apache/superset/pull/45727?src=pr&el=tree&filepath=superset%2Fai%2Fllm%2Fanthropic.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYWkvbGxtL2FudGhyb3BpYy5weQ==) | 0.00% | [216 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/45727?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [superset/ai/runtime/messages.py](https://app.codecov.io/gh/apache/superset/pull/45727?src=pr&el=tree&filepath=superset%2Fai%2Fruntime%2Fmessages.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYWkvcnVudGltZS9tZXNzYWdlcy5weQ==) | 0.00% | [194 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/45727?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [superset/ai/page\_context.py](https://app.codecov.io/gh/apache/superset/pull/45727?src=pr&el=tree&filepath=superset%2Fai%2Fpage_context.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYWkvcGFnZV9jb250ZXh0LnB5) | 0.00% | [193 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/45727?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [superset/ai/prompts/assemble.py](https://app.codecov.io/gh/apache/superset/pull/45727?src=pr&el=tree&filepath=superset%2Fai%2Fprompts%2Fassemble.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYWkvcHJvbXB0cy9hc3NlbWJsZS5weQ==) | 0.00% | [147 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/45727?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [superset/ai/eventbus.py](https://app.codecov.io/gh/apache/superset/pull/45727?src=pr&el=tree&filepath=superset%2Fai%2Feventbus.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYWkvZXZlbnRidXMucHk=) | 0.00% | [134 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/45727?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [superset/ai/mcp/config.py](https://app.codecov.io/gh/apache/superset/pull/45727?src=pr&el=tree&filepath=superset%2Fai%2Fmcp%2Fconfig.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYWkvbWNwL2NvbmZpZy5weQ==) | 0.00% | [129 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/45727?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [superset/ai/policy.py](https://app.codecov.io/gh/apache/superset/pull/45727?src=pr&el=tree&filepath=superset%2Fai%2Fpolicy.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYWkvcG9saWN5LnB5) | 0.00% | [119 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/45727?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [18 more](https://app.codecov.io/gh/apache/superset/pull/45727?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #45727       +/-   ##
   ===========================================
   - Coverage   84.26%   55.74%   -28.52%     
   ===========================================
     Files        3057     3107       +50     
     Lines      201986   206946     +4960     
     Branches    47254    47830      +576     
   ===========================================
   - Hits       170204   115371    -54833     
   - Misses      28525    90488    +61963     
   + Partials     3257     1087     -2170     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/45727/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ” | |
   |---|---|---|
   | [mysql](https://app.codecov.io/gh/apache/superset/pull/45727/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [postgres](https://app.codecov.io/gh/apache/superset/pull/45727/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [sqlite](https://app.codecov.io/gh/apache/superset/pull/45727/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [superset-extensions-cli](https://app.codecov.io/gh/apache/superset/pull/45727/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `91.24% <ΓΈ> (?)` | |
   | [unit](https://app.codecov.io/gh/apache/superset/pull/45727/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/45727?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org