You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "sarankk (via GitHub)" <gi...@apache.org> on 2024/02/08 20:55:05 UTC
[PR] CASSANDRASC-100 Fix flaky SSTableImportHandlerTest [cassandra-sidecar]
sarankk opened a new pull request, #98:
URL: https://github.com/apache/cassandra-sidecar/pull/98
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSANDRASC-100 Fix flaky SSTableImportHandlerTest [cassandra-sidecar]
Posted by "sarankk (via GitHub)" <gi...@apache.org>.
sarankk commented on code in PR #98:
URL: https://github.com/apache/cassandra-sidecar/pull/98#discussion_r1483742527
##########
src/test/java/org/apache/cassandra/sidecar/routes/sstableuploads/BaseUploadsHandlerTest.java:
##########
@@ -222,4 +229,53 @@ public SidecarConfiguration configuration()
return sidecarConfiguration;
}
}
+
+ static class TestCassandraAdapterDelegate extends CassandraAdapterDelegate
Review Comment:
But we already follow a pattern of calling such dummy classes Test<>. Example https://github.com/apache/cassandra-sidecar/blob/c72f2179143e7e031f247d3e8385a29c5e64c1c3/src/test/java/org/apache/cassandra/sidecar/routes/restore/BaseRestoreJobTests.java#L168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSANDRASC-100 Fix flaky SSTableImportHandlerTest [cassandra-sidecar]
Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh commented on PR #98:
URL: https://github.com/apache/cassandra-sidecar/pull/98#issuecomment-1936299218
Closed via https://github.com/apache/cassandra-sidecar/commit/2914d57f0428643b3a92b6af8f4da1b209d80c2a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSANDRASC-100 Fix flaky SSTableImportHandlerTest [cassandra-sidecar]
Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh commented on code in PR #98:
URL: https://github.com/apache/cassandra-sidecar/pull/98#discussion_r1483735562
##########
src/test/java/org/apache/cassandra/sidecar/routes/sstableuploads/BaseUploadsHandlerTest.java:
##########
@@ -222,4 +229,53 @@ public SidecarConfiguration configuration()
return sidecarConfiguration;
}
}
+
+ static class TestCassandraAdapterDelegate extends CassandraAdapterDelegate
Review Comment:
can we call this `FakeCassandraAdapterDelegate` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSANDRASC-100 Fix flaky SSTableImportHandlerTest [cassandra-sidecar]
Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh closed pull request #98: CASSANDRASC-100 Fix flaky SSTableImportHandlerTest
URL: https://github.com/apache/cassandra-sidecar/pull/98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org