[jira] Commented: (SOLR-601) protected QParser.parse() and subclasses

["Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605637#action_12605637 ] 

Shalin Shekhar Mangar commented on SOLR-601:
--------------------------------------------

Yonik: FooQParser#parse is not compiling after this change. It should also be changed to public:

[javac] Compiling 106 source files to /home/shalinsmangar/work/oss/solr-trunk/build/tests
[javac] /home/shalinsmangar/work/oss/solr-trunk/src/test/org/apache/solr/search/FooQParserPlugin.java:43: parse() in org.apache.solr.search.FooQParser cannot override parse() in org.apache.solr.search.QParser; attempting to assign weaker access privileges; was public
[javac]   protected Query parse() throws ParseException {
[javac]                             ^

> protected QParser.parse() and subclasses
> ----------------------------------------
>
>                 Key: SOLR-601
>                 URL: https://issues.apache.org/jira/browse/SOLR-601
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Julien Piquot
>             Fix For: 1.3
>
>
> : As QParser.parse is protected and QParser.subQuery is public, everything
> : works fine when I run parse() myself (through unit tests). But when I
> : try to run it through a Solr server, I get :
> all of the concrete impls of QParser in the solr code base declare the
> parse() method as public ... i'm not sure why it's protected in the abstract class ... seems wrong to me.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.