You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "oneonestar (via GitHub)" <gi...@apache.org> on 2024/01/17 08:38:50 UTC

[I] `write.parquet.compression-codec` being set even if file-format is not parquet [iceberg]

oneonestar opened a new issue, #9490:
URL: https://github.com/apache/iceberg/issues/9490

   ### Apache Iceberg version
   
   1.4.2 (latest release)
   
   ### Query engine
   
   Trino
   
   ### Please describe the bug 🐞
   
   In Trino 436 (Iceberg 1.4.3), `write.parquet.compression-codec` property is also being set even if the file-format is not parquet. (https://github.com/trinodb/trino/issues/20401)
   
   I think the problem could be related to
   https://github.com/apache/iceberg/pull/8593#issuecomment-1740507634
   
   ```
   trino> CREATE TABLE test.property_test (c1 integer) WITH (format = 'ORC');
   CREATE TABLE
   trino> SELECT * FROM test."property_test$properties";
                  key               | value
   ---------------------------------+-------
    write.format.default            | ORC
    write.parquet.compression-codec | zstd
   (2 rows)
   
   trino> CREATE TABLE test.property_test (c1 integer) WITH (format = 'AVRO');
   CREATE TABLE
   trino> SELECT * FROM test."property_test$properties";
                  key               | value
   ---------------------------------+-------
    write.format.default            | AVRO
    write.parquet.compression-codec | zstd
   (2 rows)
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] `write.parquet.compression-codec` being set even if file-format is not parquet [iceberg]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #9490:
URL: https://github.com/apache/iceberg/issues/9490#issuecomment-2408755008

   This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] `write.parquet.compression-codec` being set even if file-format is not parquet [iceberg]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #9490:
URL: https://github.com/apache/iceberg/issues/9490#issuecomment-2597166534

   This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] `write.parquet.compression-codec` being set even if file-format is not parquet [iceberg]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #9490: `write.parquet.compression-codec` being set even if file-format is not parquet
URL: https://github.com/apache/iceberg/issues/9490


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] `write.parquet.compression-codec` being set even if file-format is not parquet [iceberg]

Posted by "findinpath (via GitHub)" <gi...@apache.org>.
findinpath commented on issue #9490:
URL: https://github.com/apache/iceberg/issues/9490#issuecomment-1895363913

   cc @aokolnychyi  pls see `org.apache.iceberg.TableMetadata#persistedProperties` in  2e291c2b


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] `write.parquet.compression-codec` being set even if file-format is not parquet [iceberg]

Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on issue #9490:
URL: https://github.com/apache/iceberg/issues/9490#issuecomment-1897791241

   Yeah looks like we should conditionally persist those properties based on the format properties.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org