You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/06 12:22:47 UTC
[GitHub] [flink] rmetzger opened a new pull request #12007: [FLINK-17416][e2e][k8s][hotfix] Use Openjdk8 for e2e tests
rmetzger opened a new pull request #12007:
URL: https://github.com/apache/flink/pull/12007
## What is the purpose of the change
Flink K8s doesn't work with zulu 8u252.
This change replaces it with OpenJDK 8u252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #12007: [FLINK-17416][e2e][k8s][hotfix] Use Openjdk8 for e2e tests
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #12007:
URL: https://github.com/apache/flink/pull/12007#issuecomment-625027932
The test failed because we are still using openjdk version "1.8.0_252" in azure. And it could not work with okhttp 3.x.
BTW, the K8s test failed at the Flink client side, so it has nothing to do with the docker environment. Our docker image java version is "1.8.0_212".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12007: [FLINK-17416][e2e][k8s][hotfix] Use Openjdk8 for e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12007:
URL: https://github.com/apache/flink/pull/12007#issuecomment-624629417
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a742c92b6930970cc226b9ea02afed7aa7eb2db7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=694",
"triggerID" : "a742c92b6930970cc226b9ea02afed7aa7eb2db7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a742c92b6930970cc226b9ea02afed7aa7eb2db7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=694)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger edited a comment on pull request #12007: [FLINK-17416][e2e][k8s][hotfix] Use Openjdk8 for e2e tests
Posted by GitBox <gi...@apache.org>.
rmetzger edited a comment on pull request #12007:
URL: https://github.com/apache/flink/pull/12007#issuecomment-625950506
Closing this PR. The problem is more difficult than expected :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #12007: [FLINK-17416][e2e][k8s][hotfix] Use Openjdk8 for e2e tests
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #12007:
URL: https://github.com/apache/flink/pull/12007#issuecomment-625950506
Closing this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #12007: [FLINK-17416][e2e][k8s][hotfix] Use Openjdk8 for e2e tests
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #12007:
URL: https://github.com/apache/flink/pull/12007#issuecomment-624680279
kubernetes e2e test still fails; the change in this PR has no effect on the JDK within the docker container.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12007: [FLINK-17416][e2e][k8s][hotfix] Use Openjdk8 for e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12007:
URL: https://github.com/apache/flink/pull/12007#issuecomment-624629417
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a742c92b6930970cc226b9ea02afed7aa7eb2db7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a742c92b6930970cc226b9ea02afed7aa7eb2db7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a742c92b6930970cc226b9ea02afed7aa7eb2db7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12007: [FLINK-17416][e2e][k8s][hotfix] Use Openjdk8 for e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12007:
URL: https://github.com/apache/flink/pull/12007#issuecomment-624629417
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a742c92b6930970cc226b9ea02afed7aa7eb2db7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=694",
"triggerID" : "a742c92b6930970cc226b9ea02afed7aa7eb2db7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a742c92b6930970cc226b9ea02afed7aa7eb2db7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=694)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12007: [FLINK-17416][e2e][k8s][hotfix] Use Openjdk8 for e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12007:
URL: https://github.com/apache/flink/pull/12007#issuecomment-624618711
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit a742c92b6930970cc226b9ea02afed7aa7eb2db7 (Wed May 06 12:26:20 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-17416).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #12007: [FLINK-17416][e2e][k8s][hotfix] Use Openjdk8 for e2e tests
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #12007:
URL: https://github.com/apache/flink/pull/12007#issuecomment-625032862
What this PR does is changing the JDK from zulu to openjdk:
after this PR, on startup it logs:
```
Java and Maven version
openjdk version "1.8.0_252"
OpenJDK Runtime Environment (build 1.8.0_252-8u252-b09-1~16.04-b09)
OpenJDK 64-Bit Server VM (build 25.252-b09, mixed mode)
Invoking mvn with '/home/vsts/maven_cache/apache-maven-3.2.5/bin/mvn -Dmaven.wagon.http.pool=false --settings /home/vsts/work/1/s/tools/ci/google-mirror-settings.xml -Dorg.slf4j.simpleLogger.showDateTime=true -Dorg.slf4j.simpleLogger.dateTimeFormat=HH:mm:ss.SSS -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn --no-snapshot-updates -B -Dinclude-hadoop -Dhadoop.version=2.8.3 -Dinclude_hadoop_aws -Dscala-2.11 -Pe2e-hadoop -version'
Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-14T17:29:23+00:00)
```
Before this PR, it logs:
```
Java and Maven version
openjdk version "1.8.0_252"
OpenJDK Runtime Environment (Zulu 8.46.0.19-linux64)-Microsoft-Azure-restricted (build 1.8.0_252-b14)
OpenJDK 64-Bit Server VM (Zulu 8.46.0.19-linux64)-Microsoft-Azure-restricted (build 25.252-b14, mixed mode)
Invoking mvn with '/home/vsts/maven_cache/apache-maven-3.2.5/bin/mvn -Dmaven.wagon.http.pool=false --settings /home/vsts/work/1/s/tools/ci/google-mirror-settings.xml -Dorg.slf4j.simpleLogger.showDateTime=true -Dorg.slf4j.simpleLogger.dateTimeFormat=HH:mm:ss.SSS -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn --no-snapshot-updates -B -Dinclude-hadoop -Dhadoop.version=2.8.3 -Dinclude_hadoop_aws -Dscala-2.11 -Pe2e-hadoop -version'
Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-14T17:29:23+00:00)
```
I thought the okhttp problem was caused by the zulu vm, but it seems to apply to openjdk as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org