[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28923: [SPARK-32090][SQL] UserDefinedType.equal() should be symmetrical

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #28923:
URL: https://github.com/apache/spark/pull/28923#discussion_r446690196



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala
##########
@@ -134,6 +134,17 @@ class UserDefinedTypeSuite extends QueryTest with SharedSparkSession with Parque
     MyLabeledPoint(1.0, new TestUDT.MyDenseVector(Array(0.1, 1.0))),
     MyLabeledPoint(0.0, new TestUDT.MyDenseVector(Array(0.3, 3.0)))).toDF()
 
+
+  test("equal") {

Review comment:
       BTW, @Ngone51 . Although it seems to be considered as `Improvement` and should be `Improvement` due to the behavior change, it would be better if we have a test prefix `SPARK-32090: ` here in this PR. If you don't mind, please add it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org