[jira] [Commented] (COUCHDB-2866) Explicitly starting lager causes config_tests to fail when used in builds which don't use depend on lager

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COUCHDB-2866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984638#comment-14984638 ] 

ASF GitHub Bot commented on COUCHDB-2866:
-----------------------------------------

GitHub user jaydoane opened a pull request:

    https://github.com/apache/couchdb-config/pull/7

    Don't start lager during setup for each config_test

    BugzID: 55507
    COUCHDB-2866

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudant/couchdb-config 55507-config_tests-remove-lager

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-config/pull/7.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #7
    
----
commit 4d08e1c0c3a7bdd5bb71bab17c8b54b70ff934d4
Author: Jay Doane <ja...@gmail.com>
Date:   2015-11-02T02:11:17Z

    Don't start lager during setup for each config_test
    
    BugzID: 55507
    COUCHDB-2866

----


> Explicitly starting lager causes config_tests to fail when used in builds which don't use depend on lager
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: COUCHDB-2866
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-2866
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Test Suite
>            Reporter: Jay Doane
>
> https://github.com/apache/couchdb-config/blob/master/test/config_tests.erl#L40
> explicitly starts the lager application for setup in each config_test, which fails in builds such as Cloudant PaaS (which doesn't depend on lager).
> Reference to lager can safely be removed, and the tests continue to pass when run under CouchDB eunit suite. Patch forthcoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)