You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ravinarayansingh (via GitHub)" <gi...@apache.org> on 2024/06/23 06:32:26 UTC
[PR] NIFI-11858 new PR for Configurable Column Name Normalization in PutDatabaseRecord and UpdateDatabaseTable [nifi]
ravinarayansingh opened a new pull request, #8995:
URL: https://github.com/apache/nifi/pull/8995
old PR link : [NIFI-11858](https://github.com/apache/nifi/pull/7544)
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-11858 ](https://issues.apache.org/jira/browse/NIFI-11858 )
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 21
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-11858 Configurable Column Name Normalization in PutDatabaseRecord and UpdateDatabaseTable [nifi]
Posted by "mattyb149 (via GitHub)" <gi...@apache.org>.
mattyb149 commented on PR #8995:
URL: https://github.com/apache/nifi/pull/8995#issuecomment-2352886441
I apologize for losing track of this, but now there are merge conflicts. Once the conflicts are resolved I will finish the review and hopefully it is ready for merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-11858 Configurable Column Name Normalization in PutDatabaseRecord and UpdateDatabaseTable [nifi]
Posted by "mattyb149 (via GitHub)" <gi...@apache.org>.
mattyb149 commented on PR #8995:
URL: https://github.com/apache/nifi/pull/8995#issuecomment-2318444726
There are merge conflicts here, I recommend not merging main into your feature branch but rather pulling down the latest main then checking out your feature branch and rebasing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-11858 Configurable Column Name Normalization in PutDatabaseRecord and UpdateDatabaseTable [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory closed pull request #8995: NIFI-11858 Configurable Column Name Normalization in PutDatabaseRecord and UpdateDatabaseTable
URL: https://github.com/apache/nifi/pull/8995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-11858 Configurable Column Name Normalization in PutDatabaseRecord and UpdateDatabaseTable [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on PR #8995:
URL: https://github.com/apache/nifi/pull/8995#issuecomment-2408617838
Closing in favor of updated PR #9382.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-11858 Configurable Column Name Normalization in PutDatabaseRecord and UpdateDatabaseTable [nifi]
Posted by "mattyb149 (via GitHub)" <gi...@apache.org>.
mattyb149 commented on code in PR #8995:
URL: https://github.com/apache/nifi/pull/8995#discussion_r1653289944
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/TranslationStrategy.java:
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.standard.db;
+
+import org.apache.nifi.components.DescribedValue;
+
+/**
+ * Enumeration of supported Database column name Translation Strategies
+ */
+public enum TranslationStrategy implements DescribedValue {
+ REMOVE_UNDERSCORE("Remove Underscore",
+ "Underscores '_' will be removed from column names Ex: 'Pics_1_23' becomes 'PICS123'"),
+ REMOVE_SPACE("Remove Space",
+ "Spaces will be removed from column names Ex. 'User Name' becomes 'USERNAME'"),
+ REMOVE_ALL_SPECIAL_CHAR("Remove Regular Expression Characters", "Remove Regular Expression Characters"),
Review Comment:
Do you think we should allow not normalizing the upper/lower case? Also since the list isn't long it might be worthwhile to add a "Remove Underscores and Spaces" option. Regular Expressions can get pretty gnarly and the more use cases we can anticipate the better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-11858 Configurable Column Name Normalization in PutDatabaseRecord and UpdateDatabaseTable [nifi]
Posted by "ravinarayansingh (via GitHub)" <gi...@apache.org>.
ravinarayansingh commented on PR #8995:
URL: https://github.com/apache/nifi/pull/8995#issuecomment-2408282427
hi @mattyb149
i have create new PR https://github.com/apache/nifi/pull/9382
please have a look we can close this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-11858 Configurable Column Name Normalization in PutDatabaseRecord and UpdateDatabaseTable [nifi]
Posted by "mattyb149 (via GitHub)" <gi...@apache.org>.
mattyb149 commented on PR #8995:
URL: https://github.com/apache/nifi/pull/8995#issuecomment-2408108228
Unfortunately this PR is not in good shape to merge. Do you have a list of the commits you added as part of this PR vs the merge commits or any other change you didn't initiate? I can help put up a more viable PR with only your commits against the latest Apache NiFi main branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-11858 Configurable Column Name Normalization in PutDatabaseRecord and UpdateDatabaseTable [nifi]
Posted by "ravinarayansingh (via GitHub)" <gi...@apache.org>.
ravinarayansingh commented on PR #8995:
URL: https://github.com/apache/nifi/pull/8995#issuecomment-2334347432
hi @mattyb149
let me know if any thing need to be done form my side
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-11858 Configurable Column Name Normalization in PutDatabaseRecord and UpdateDatabaseTable [nifi]
Posted by "ravinarayansingh (via GitHub)" <gi...@apache.org>.
ravinarayansingh commented on code in PR #8995:
URL: https://github.com/apache/nifi/pull/8995#discussion_r1670915680
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/TranslationStrategy.java:
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.standard.db;
+
+import org.apache.nifi.components.DescribedValue;
+
+/**
+ * Enumeration of supported Database column name Translation Strategies
+ */
+public enum TranslationStrategy implements DescribedValue {
+ REMOVE_UNDERSCORE("Remove Underscore",
+ "Underscores '_' will be removed from column names Ex: 'Pics_1_23' becomes 'PICS123'"),
+ REMOVE_SPACE("Remove Space",
+ "Spaces will be removed from column names Ex. 'User Name' becomes 'USERNAME'"),
+ REMOVE_ALL_SPECIAL_CHAR("Remove Regular Expression Characters", "Remove Regular Expression Characters"),
Review Comment:
@mattyb149 let me know if there is any change required from my side
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-11858 Configurable Column Name Normalization in PutDatabaseRecord and UpdateDatabaseTable [nifi]
Posted by "ravinarayansingh (via GitHub)" <gi...@apache.org>.
ravinarayansingh commented on PR #8995:
URL: https://github.com/apache/nifi/pull/8995#issuecomment-2319706122
> There are merge conflicts here, I recommend not merging main into your feature branch but rather pulling down the latest main then checking out your feature branch and rebasing.
@mattyb149 I have resolved the conflict and rebased .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-11858 Configurable Column Name Normalization in PutDatabaseRecord and UpdateDatabaseTable [nifi]
Posted by "ravinarayansingh (via GitHub)" <gi...@apache.org>.
ravinarayansingh commented on PR #8995:
URL: https://github.com/apache/nifi/pull/8995#issuecomment-2364033652
> I apologize for losing track of this, but now there are merge conflicts. Once the conflicts are resolved I will finish the review and hopefully it is ready for merging.
Hi @mattyb149
I have resolved the conflict please have a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org