[GitHub] [spark] cloud-fan commented on issue #26031: [SPARK-29362][SQL] Move timestamp expressions and tests to separate files

[GitBox <gi...@apache.org>]

cloud-fan commented on issue #26031: [SPARK-29362][SQL] Move timestamp expressions and tests to separate files
URL: https://github.com/apache/spark/pull/26031#issuecomment-538825362
 
 
   This is a tradeoff that we need to evaluate. We should not blindly reject any cross-file code movement simply because it makes commit tracking harder. Users can still find the code movement commit and continue to look at the commits of the old file. It's still doable but harder.
   
   For this particular case, I think `datetimeExpressions.scala` is OK to hold the date and timestamp expressions. It's better to split into 2 files as it has grown too big, we should do it if we are going to add many more datetime expressions later.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org