[GitHub] milleruntime commented on a change in pull request #456: Add ZStandard compression codec. Fixes #438

[GitBox <gi...@apache.org>]

milleruntime commented on a change in pull request #456: Add ZStandard compression codec. Fixes #438
URL: https://github.com/apache/accumulo/pull/456#discussion_r186464090
 
 

 ##########
 File path: client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/FileOutputConfigurator.java
 ##########
 @@ -135,14 +135,15 @@ public static AccumuloConfiguration getAccumuloConfiguration(Class<?> implementi
    * @param conf
    *          the Hadoop configuration object to configure
    * @param compressionType
-   *          one of "none", "gz", "lzo", or "snappy"
+   *          one of "none", "gz", "lzo", "snappy", or "zst"
 
 Review comment:
   I went back and forth between those names.  I had `zstd` everywhere until I saw this: https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/ZStandardCodec.java#L232

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services