You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2022/11/14 04:07:55 UTC
[GitHub] [submarine] cdmikechen opened a new pull request, #1015: SUBMARINE-1152. Submarine UI support i18n
cdmikechen opened a new pull request, #1015:
URL: https://github.com/apache/submarine/pull/1015
### What is this PR for?
UI support translation by [@ngx-translate/core](https://github.com/ngx-translate/core)
### What type of PR is it?
Feature
### Todos
* [x] - Add @ngx-translate/core lib
* [x] - Translate `Experiment` page
### What is the Jira issue?
https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-1152
### How should this be tested?
See Screenshot
### Screenshots (if appropriate)
https://user-images.githubusercontent.com/12069428/201573071-bcf2d4f5-7e79-4fef-a9ad-7dd695697f13.mov
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? Yes
* Does this need new documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] codecov[bot] commented on pull request #1015: SUBMARINE-1152. Submarine UI support i18n
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1015:
URL: https://github.com/apache/submarine/pull/1015#issuecomment-1313068962
# [Codecov](https://codecov.io/gh/apache/submarine/pull/1015?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1015](https://codecov.io/gh/apache/submarine/pull/1015?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b31ff43) into [master](https://codecov.io/gh/apache/submarine/commit/dd6a292414d3e1547d5603c8daceddabdda6d6ae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dd6a292) will **increase** coverage by `29.46%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1015 +/- ##
=============================================
+ Coverage 22.71% 52.18% +29.46%
=============================================
Files 358 112 -246
Lines 29088 4944 -24144
Branches 3479 0 -3479
=============================================
- Hits 6608 2580 -4028
+ Misses 22266 2364 -19902
+ Partials 214 0 -214
```
| Flag | Coverage Δ | |
|---|---|---|
| python-integration | `?` | |
| python-unit | `52.18% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/submarine/pull/1015?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ine-sdk/pysubmarine/submarine/models/tensorflow.py](https://codecov.io/gh/apache/submarine/pull/1015/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvbW9kZWxzL3RlbnNvcmZsb3cucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...submarine/store/model\_registry/sqlalchemy\_store.py](https://codecov.io/gh/apache/submarine/pull/1015/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvc3RvcmUvbW9kZWxfcmVnaXN0cnkvc3FsYWxjaGVteV9zdG9yZS5weQ==) | `21.57% <0.00%> (-75.52%)` | :arrow_down: |
| [...k/pysubmarine/submarine/client/api/notebook\_api.py](https://codecov.io/gh/apache/submarine/pull/1015/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvY2xpZW50L2FwaS9ub3RlYm9va19hcGkucHk=) | `12.97% <0.00%> (-66.42%)` | :arrow_down: |
| [...ysubmarine/submarine/client/api/environment\_api.py](https://codecov.io/gh/apache/submarine/pull/1015/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvY2xpZW50L2FwaS9lbnZpcm9ubWVudF9hcGkucHk=) | `12.31% <0.00%> (-62.32%)` | :arrow_down: |
| [...arine-sdk/pysubmarine/submarine/tracking/client.py](https://codecov.io/gh/apache/submarine/pull/1015/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvdHJhY2tpbmcvY2xpZW50LnB5) | `30.37% <0.00%> (-55.70%)` | :arrow_down: |
| [...-sdk/pysubmarine/submarine/cli/notebook/command.py](https://codecov.io/gh/apache/submarine/pull/1015/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvY2xpL25vdGVib29rL2NvbW1hbmQucHk=) | `26.19% <0.00%> (-53.58%)` | :arrow_down: |
| [...k/pysubmarine/submarine/cli/environment/command.py](https://codecov.io/gh/apache/submarine/pull/1015/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvY2xpL2Vudmlyb25tZW50L2NvbW1hbmQucHk=) | `26.19% <0.00%> (-53.58%)` | :arrow_down: |
| [...dk/pysubmarine/submarine/cli/experiment/command.py](https://codecov.io/gh/apache/submarine/pull/1015/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvY2xpL2V4cGVyaW1lbnQvY29tbWFuZC5weQ==) | `25.55% <0.00%> (-52.23%)` | :arrow_down: |
| [...ine-sdk/pysubmarine/submarine/client/api\_client.py](https://codecov.io/gh/apache/submarine/pull/1015/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvY2xpZW50L2FwaV9jbGllbnQucHk=) | `20.14% <0.00%> (-42.41%)` | :arrow_down: |
| [...pysubmarine/submarine/client/api/experiment\_api.py](https://codecov.io/gh/apache/submarine/pull/1015/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvY2xpZW50L2FwaS9leHBlcmltZW50X2FwaS5weQ==) | `10.34% <0.00%> (-41.38%)` | :arrow_down: |
| ... and [312 more](https://codecov.io/gh/apache/submarine/pull/1015/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] cdmikechen commented on pull request #1015: SUBMARINE-1152. Submarine UI support i18n
Posted by GitBox <gi...@apache.org>.
cdmikechen commented on PR #1015:
URL: https://github.com/apache/submarine/pull/1015#issuecomment-1331611955
@pingsutw
Hi~ There are a few changes that depend on this PR, so I've gone ahead with the merge for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #1015: SUBMARINE-1152. Submarine UI support i18n
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1015: SUBMARINE-1152. Submarine UI support i18n
URL: https://github.com/apache/submarine/pull/1015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org