You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/02/15 18:56:48 UTC

[GitHub] jaylindquist opened a new pull request #4437: Fix separator visualization by propagating header height - Resolves issue #3619

jaylindquist opened a new pull request #4437: Fix separator visualization by propagating header height - Resolves issue #3619
URL: https://github.com/apache/incubator-superset/pull/4437
 
 
   This fix is to resolves issue #3619 
   
   The separator slice is using an iframe with a height smaller than the chart's container. This causes the text to be truncated and a scroll bar to appear. This is because the markup chart shares the same visualization as separators and the styling has been updated to work with markup only.
   
   Before the attached changes, you can see markup charts look correct while separators are cut off:
   
   ![separator-fix-before](https://user-images.githubusercontent.com/222699/36275120-8fff157e-124f-11e8-99ec-06716b8d8da6.png)
   
   After the changes, both charts are sized correctly:
   ![separator-fix-after](https://user-images.githubusercontent.com/222699/36275130-95e72530-124f-11e8-9f87-addac8900df1.PNG)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services