[GitHub] [beam] damccorm commented on a diff in pull request #28513: Report total active threads

["damccorm (via GitHub)" <gi...@apache.org>]

damccorm commented on code in PR #28513:
URL: https://github.com/apache/beam/pull/28513#discussion_r1340166310


##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -2027,6 +2034,10 @@ private void updateVMMetrics() {
   private void updateThreadMetrics() {
     timeAtMaxActiveThreads.getAndReset();
     timeAtMaxActiveThreads.addValue(workUnitExecutor.allThreadsActiveTime());
+    activeThreads.getAndReset();
+    activeThreads.addValue(workUnitExecutor.activeCount());
+    maxActiveThreads.getAndReset();
+    maxActiveThreads.addValue(chooseMaximumNumberOfThreads());

Review Comment:
   This also doesn't make sense to me. If `numberOfWorkerHarnessThreads` is good enough, why don't we just use that? If we eventually decide to adjust the thread limit, can't we react at that point?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org