You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/04/22 07:57:00 UTC
[GitHub] [hive] Qidong-Zhang opened a new pull request #2204: HIVE-24944: When the default engine of the hiveserver is MR and the t…
Qidong-Zhang opened a new pull request #2204:
URL: https://github.com/apache/hive/pull/2204
What changes were proposed in this pull request?
See the: https://issues.apache.org/jira/browse/HIVE-24944
Why are the changes needed?
When the default engine of the hiveserver is MR and the tez engine is set by the client, the client TEZ progress log cannot be printed normally
Does this PR introduce any user-facing change?
No
How was this patch tested?
Remote cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #2204: HIVE-24944: When the default engine of the hiveserver is MR and the t…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #2204:
URL: https://github.com/apache/hive/pull/2204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on pull request #2204: HIVE-24944: When the default engine of the hiveserver is MR and the t…
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on pull request #2204:
URL: https://github.com/apache/hive/pull/2204#issuecomment-847499225
Hi @anishek, could you please take another look on the changes? thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] Qidong-Zhang commented on pull request #2204: HIVE-24944: When the default engine of the hiveserver is MR and the t…
Posted by GitBox <gi...@apache.org>.
Qidong-Zhang commented on pull request #2204:
URL: https://github.com/apache/hive/pull/2204#issuecomment-864681946
Hi @belugabehr @dengzhhu653 @thejasmn @kgyrtkirk @anishek
Please check the submission record，thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr edited a comment on pull request #2204: HIVE-24944: When the default engine of the hiveserver is MR and the t…
Posted by GitBox <gi...@apache.org>.
belugabehr edited a comment on pull request #2204:
URL: https://github.com/apache/hive/pull/2204#issuecomment-852419901
Looks alright. Can you do me a quick favor and switch statement it?
```java
switch(engineInSessionConf) {
case "tez":
case "mr":
default:
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on pull request #2204: HIVE-24944: When the default engine of the hiveserver is MR and the t…
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on pull request #2204:
URL: https://github.com/apache/hive/pull/2204#issuecomment-869315915
lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #2204: HIVE-24944: When the default engine of the hiveserver is MR and the t…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #2204:
URL: https://github.com/apache/hive/pull/2204#issuecomment-907533741
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a change in pull request #2204: HIVE-24944: When the default engine of the hiveserver is MR and the t…
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on a change in pull request #2204:
URL: https://github.com/apache/hive/pull/2204#discussion_r659451245
##########
File path: service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
##########
@@ -794,11 +794,20 @@ public TGetOperationStatusResp GetOperationStatus(TGetOperationStatusReq req) th
}
JobProgressUpdate progressUpdate = operationStatus.jobProgressUpdate();
ProgressMonitorStatusMapper mapper = ProgressMonitorStatusMapper.DEFAULT;
- if ("tez".equals(hiveConf.getVar(ConfVars.HIVE_EXECUTION_ENGINE))) {
- mapper = new TezProgressMonitorStatusMapper();
- }
- if ("spark".equals(hiveConf.getVar(ConfVars.HIVE_EXECUTION_ENGINE))) {
- mapper = new SparkProgressMonitorStatusMapper();
+ String engineInSessionConf = cliService.getSessionManager().getOperationManager()
+ .getOperation(operationHandle)
+ .getParentSession()
+ .getHiveConf()
+ .getVar(ConfVars.HIVE_EXECUTION_ENGINE);
+ switch (engineInSessionConf) {
+ case "tez":
+ mapper = new TezProgressMonitorStatusMapper();
+ break;
+ case "spark":
+ mapper = new SparkProgressMonitorStatusMapper();
+ break;
+ default:
Review comment:
nit: maybe we could remove the `default` execution path here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 removed a comment on pull request #2204: HIVE-24944: When the default engine of the hiveserver is MR and the t…
Posted by GitBox <gi...@apache.org>.
dengzhhu653 removed a comment on pull request #2204:
URL: https://github.com/apache/hive/pull/2204#issuecomment-869315915
lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on pull request #2204: HIVE-24944: When the default engine of the hiveserver is MR and the t…
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on pull request #2204:
URL: https://github.com/apache/hive/pull/2204#issuecomment-851899226
Hey @thejasmn, @kgyrtkirk could you please take another look if have secs?
thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr commented on pull request #2204: HIVE-24944: When the default engine of the hiveserver is MR and the t…
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #2204:
URL: https://github.com/apache/hive/pull/2204#issuecomment-852419901
Looks alright. Can you do me a quick favor and case statement it?
```java
switch(engineInSessionConf) {
case "tez":
case "mr":
default:
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org