[GitHub] [kafka] mjsax commented on a change in pull request #8646: KAFKA-9974: Fix flaky test by removing unneeded asserts

[GitBox <gi...@apache.org>]

mjsax commented on a change in pull request #8646:
URL: https://github.com/apache/kafka/pull/8646#discussion_r429501759



##########
File path: streams/src/test/java/org/apache/kafka/streams/integration/OptimizedKTableIntegrationTest.java
##########
@@ -133,11 +133,6 @@ public void shouldApplyUpdatesToStandbyStore() throws Exception {
             kafkaStreams1WasFirstActive = false;
         }
 
-        // Assert that no restore has occurred, ensures that when we check later that the restore
-        // notification actually came from after the rebalance.
-        assertThat(listener.startOffset, is(equalTo(0L)));
-        assertThat(listener.totalNumRestored, is(equalTo(0L)));

Review comment:
       I am not 100% sure about the root cause of the issue... If you have a good suggestion for a better error message, that would be great. I have not idea how we could improve it atm.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org