You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Paul Isaychuk <pi...@hortonworks.com> on 2014/10/16 15:12:36 UTC
Review Request 26808: [FALCON-814] Tests for entities summary API.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26808/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-814
https://issues.apache.org/jira/browse/FALCON-814
Repository: falcon-git
Description
-------
Tests for entities summary API.
Diffs
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java 8e55493
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 52f1bc1
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/ServiceResponse.java 3c5bd9e
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 1d07fc5
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/26808/diff/
Testing
-------
tested
Thanks,
Paul Isaychuk
Re: Review Request 26808: [FALCON-814] Tests for entities summary API.
Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26808/#review58605
-----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java
<https://reviews.apache.org/r/26808/#comment99674>
Arrays.toString() expected
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java
<https://reviews.apache.org/r/26808/#comment99675>
Arrays.toString expected
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java
<https://reviews.apache.org/r/26808/#comment99672>
Only first element is used
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java
<https://reviews.apache.org/r/26808/#comment99673>
A lot of accerts. SoftAccert can be usefull here
- Ruslan Ostafiychuk
On Oct. 20, 2014, 8:54 a.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26808/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2014, 8:54 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-814
> https://issues.apache.org/jira/browse/FALCON-814
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Tests for entities summary API.
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java 8e55493
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 52f1bc1
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/ServiceResponse.java 3c5bd9e
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 1d07fc5
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26808/diff/
>
>
> Testing
> -------
>
> tested
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 26808: [FALCON-814] Tests for entities summary API.
Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26808/#review58783
-----------------------------------------------------------
Ship it!
Ship It!
- Ruslan Ostafiychuk
On Oct. 28, 2014, 9:21 a.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26808/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 9:21 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-814
> https://issues.apache.org/jira/browse/FALCON-814
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Tests for entities summary API.
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java 8e55493
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 52f1bc1
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/ServiceResponse.java 3c5bd9e
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 1d07fc5
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26808/diff/
>
>
> Testing
> -------
>
> tested
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 26808: [FALCON-814] Tests for entities summary API.
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26808/
-----------------------------------------------------------
(Updated Oct. 28, 2014, 9:21 a.m.)
Review request for Falcon.
Changes
-------
few changes
Bugs: FALCON-814
https://issues.apache.org/jira/browse/FALCON-814
Repository: falcon-git
Description
-------
Tests for entities summary API.
Diffs (updated)
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java 8e55493
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 52f1bc1
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/ServiceResponse.java 3c5bd9e
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 1d07fc5
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/26808/diff/
Testing
-------
tested
Thanks,
Paul Isaychuk
Re: Review Request 26808: [FALCON-814] Tests for entities summary API.
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26808/
-----------------------------------------------------------
(Updated Oct. 27, 2014, 4:46 p.m.)
Review request for Falcon.
Changes
-------
Comments addressed
Bugs: FALCON-814
https://issues.apache.org/jira/browse/FALCON-814
Repository: falcon-git
Description
-------
Tests for entities summary API.
Diffs (updated)
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java 8e55493
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 52f1bc1
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/ServiceResponse.java 3c5bd9e
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 1d07fc5
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/26808/diff/
Testing
-------
tested
Thanks,
Paul Isaychuk
Re: Review Request 26808: [FALCON-814] Tests for entities summary API.
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26808/
-----------------------------------------------------------
(Updated Oct. 20, 2014, 8:54 a.m.)
Review request for Falcon.
Changes
-------
tagged, amended
Bugs: FALCON-814
https://issues.apache.org/jira/browse/FALCON-814
Repository: falcon-git
Description
-------
Tests for entities summary API.
Diffs (updated)
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java 8e55493
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 52f1bc1
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/ServiceResponse.java 3c5bd9e
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 1d07fc5
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/26808/diff/
Testing
-------
tested
Thanks,
Paul Isaychuk