[GitHub] [pulsar] tisonkun commented on a diff in pull request #20242: [fix][client] Java Client's Seek Logic Not Threadsafe #1

["tisonkun (via GitHub)" <gi...@apache.org>]

tisonkun commented on code in PR #20242:
URL: https://github.com/apache/pulsar/pull/20242#discussion_r1186831548


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java:
##########
@@ -2153,9 +2153,14 @@ private CompletableFuture<Void> seekAsyncInternal(long requestId, ByteBuf seek,
 
         MessageIdAdv originSeekMessageId = seekMessageId;
         seekMessageId = (MessageIdAdv) seekId;
-        duringSeek.set(true);
+        
+        if (!duringSeek.compareAndSet(false, true)) {
+            log.warn("[{}][{}] Attempting to seek operation that is already in progress, cancelling {}", 
+                    topic, subscription, seekBy);
+            seekFuture.cancel(true);

Review Comment:
   Also, this is a local future, that I believe you can complete it properly (@michaeljmarshall shall we complete with `null` or exception here?) instead of call `cancel`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org