You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/29 12:44:55 UTC
[GitHub] [superset] michael-s-molina opened a new issue #17286: Replace shortid with uuid
michael-s-molina opened a new issue #17286:
URL: https://github.com/apache/superset/issues/17286
**Is your feature request related to a problem? Please describe.**
[shortid](https://github.com/dylang/shortid) is deprecated, because the architecture is unsafe, it does not generate cryptographically secure ids and we can't rely on it to make IDs which are impossible to guess.
**Describe the solution you'd like**
We should replace its occurrences with [uuid](https://github.com/uuidjs/uuid) to generate secure ids and also to benefit from performance gains of using a database native type.
**Describe alternatives you've considered**
[nanoid](https://github.com/ai/nanoid/) was considered but the benefits of using the native `uuid` type seems more appealing.
@rusackas @villebro @etr2460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on issue #17286: Replace shortid with uuid
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #17286:
URL: https://github.com/apache/superset/issues/17286#issuecomment-956428455
@michael-s-molina in which places Superset need secure ids? I know many places use shortid as unique id, it doesn't matter you can guess it out or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rumbin commented on issue #17286: Replace shortid with uuid
Posted by GitBox <gi...@apache.org>.
rumbin commented on issue #17286:
URL: https://github.com/apache/superset/issues/17286#issuecomment-958691793
For reasons of data analytics of this data on non-indexed data warehouses, I'd like to suggest [ULID](https://github.com/ulid/spec).
Very similar to the features of UUIF, but lexicographically sortable in a meaningful way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on issue #17286: Replace shortid with uuid
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #17286:
URL: https://github.com/apache/superset/issues/17286#issuecomment-956428455
@michael-s-molina in which places Superset need secure ids? I know many places use shortid as unique id, it doesn't matter you can guess it out or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat edited a comment on issue #17286: Replace shortid with uuid
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on issue #17286:
URL: https://github.com/apache/superset/issues/17286#issuecomment-956428455
@michael-s-molina in which places Superset need secure ids? I know many places use shortid as unique UI component id, it doesn't matter you can guess it out or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat edited a comment on issue #17286: Replace shortid with uuid
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on issue #17286:
URL: https://github.com/apache/superset/issues/17286#issuecomment-956428455
@michael-s-molina in which places Superset need secure ids? I know many places use shortid as unique UI component id, it doesn't matter you can guess it out or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rumbin commented on issue #17286: Replace shortid with uuid
Posted by GitBox <gi...@apache.org>.
rumbin commented on issue #17286:
URL: https://github.com/apache/superset/issues/17286#issuecomment-958691793
For reasons of data analytics of this data on non-indexed data warehouses, I'd like to suggest [ULID](https://github.com/ulid/spec).
Very similar to the features of UUIF, but lexicographically sortable in a meaningful way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rumbin commented on issue #17286: Replace shortid with uuid
Posted by GitBox <gi...@apache.org>.
rumbin commented on issue #17286:
URL: https://github.com/apache/superset/issues/17286#issuecomment-958691793
For reasons of data analytics of this data on non-indexed data warehouses, I'd like to suggest [ULID](https://github.com/ulid/spec).
Very similar to the features of UUIF, but lexicographically sortable in a meaningful way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rumbin commented on issue #17286: Replace shortid with uuid
Posted by GitBox <gi...@apache.org>.
rumbin commented on issue #17286:
URL: https://github.com/apache/superset/issues/17286#issuecomment-958691793
For reasons of data analytics of this data on non-indexed data warehouses, I'd like to suggest [ULID](https://github.com/ulid/spec).
Very similar to the features of UUIF, but lexicographically sortable in a meaningful way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org