You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2012/06/09 01:19:22 UTC

[jira] [Created] (LUCENE-4125) AvoidCodecs (and maybe similar nearby logic) still runs BeforeClass

Robert Muir created LUCENE-4125:
-----------------------------------

             Summary: AvoidCodecs (and maybe similar nearby logic) still runs BeforeClass
                 Key: LUCENE-4125
                 URL: https://issues.apache.org/jira/browse/LUCENE-4125
             Project: Lucene - Java
          Issue Type: Bug
    Affects Versions: 4.0
            Reporter: Robert Muir


ant test-core -Dtestcase=TestBackwardsCompatibility -Dtests.codec=Lucene3x

This test isnt allowed to run Lucene3x, but the assumption stuff is per-method, it still loads things up in beforeClass, meaning we checkindex() real 3.x segments with the "fake" 3.x impersonator and it looks like corruption, which is really scary if you are just trying to run all the tests with -Dtests.codec=Lucene3x to verify a change doesnt break backwards compat.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4125) AvoidCodecs (and maybe similar nearby logic) still runs BeforeClass

Posted by "Dawid Weiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292399#comment-13292399 ] 

Dawid Weiss commented on LUCENE-4125:
-------------------------------------

Hmm... I get this when I specify -Dtests.codec=Lucene3x (trunk):

{noformat}
  [junit4] ERROR   0.00s | TestBackwardsCompatibility (suite)
   [junit4]    > Throwable #1: java.lang.IllegalArgumentException: A SPI class of type org.apache.lucene.codecs.Codec with name 'Lucene3x' does not exist. You need to add the corresponding JAR file supporting this SPI to your classpath.The current classpath supports the following names: [Lucene40, SimpleText, Appending]
{noformat}

Do I need to uncomment that code block that initializes Lucene3x?
                
> AvoidCodecs (and maybe similar nearby logic) still runs BeforeClass
> -------------------------------------------------------------------
>
>                 Key: LUCENE-4125
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4125
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>
> ant test-core -Dtestcase=TestBackwardsCompatibility -Dtests.codec=Lucene3x
> This test isnt allowed to run Lucene3x, but the assumption stuff is per-method, it still loads things up in beforeClass, meaning we checkindex() real 3.x segments with the "fake" 3.x impersonator and it looks like corruption, which is really scary if you are just trying to run all the tests with -Dtests.codec=Lucene3x to verify a change doesnt break backwards compat.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4125) AvoidCodecs (and maybe similar nearby logic) still runs BeforeClass

Posted by "Dawid Weiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292207#comment-13292207 ] 

Dawid Weiss commented on LUCENE-4125:
-------------------------------------

Found it, it's in LUCENE-4102. I'll take care of it.
                
> AvoidCodecs (and maybe similar nearby logic) still runs BeforeClass
> -------------------------------------------------------------------
>
>                 Key: LUCENE-4125
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4125
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>
> ant test-core -Dtestcase=TestBackwardsCompatibility -Dtests.codec=Lucene3x
> This test isnt allowed to run Lucene3x, but the assumption stuff is per-method, it still loads things up in beforeClass, meaning we checkindex() real 3.x segments with the "fake" 3.x impersonator and it looks like corruption, which is really scary if you are just trying to run all the tests with -Dtests.codec=Lucene3x to verify a change doesnt break backwards compat.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4125) AvoidCodecs (and maybe similar nearby logic) still runs BeforeClass

Posted by "Dawid Weiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292205#comment-13292205 ] 

Dawid Weiss commented on LUCENE-4125:
-------------------------------------

I think I provided a patch for this a while ago (as part of another issue)... searching archives.
                
> AvoidCodecs (and maybe similar nearby logic) still runs BeforeClass
> -------------------------------------------------------------------
>
>                 Key: LUCENE-4125
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4125
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>
> ant test-core -Dtestcase=TestBackwardsCompatibility -Dtests.codec=Lucene3x
> This test isnt allowed to run Lucene3x, but the assumption stuff is per-method, it still loads things up in beforeClass, meaning we checkindex() real 3.x segments with the "fake" 3.x impersonator and it looks like corruption, which is really scary if you are just trying to run all the tests with -Dtests.codec=Lucene3x to verify a change doesnt break backwards compat.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4125) AvoidCodecs (and maybe similar nearby logic) still runs BeforeClass

Posted by "Dawid Weiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292404#comment-13292404 ] 

Dawid Weiss commented on LUCENE-4125:
-------------------------------------

Ok, I see -- on branch_4x this works fine now.

                
> AvoidCodecs (and maybe similar nearby logic) still runs BeforeClass
> -------------------------------------------------------------------
>
>                 Key: LUCENE-4125
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4125
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>             Fix For: 4.0, 5.0
>
>
> ant test-core -Dtestcase=TestBackwardsCompatibility -Dtests.codec=Lucene3x
> This test isnt allowed to run Lucene3x, but the assumption stuff is per-method, it still loads things up in beforeClass, meaning we checkindex() real 3.x segments with the "fake" 3.x impersonator and it looks like corruption, which is really scary if you are just trying to run all the tests with -Dtests.codec=Lucene3x to verify a change doesnt break backwards compat.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Resolved] (LUCENE-4125) AvoidCodecs (and maybe similar nearby logic) still runs BeforeClass

Posted by "Dawid Weiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dawid Weiss resolved LUCENE-4125.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 5.0
                   4.0
         Assignee: Dawid Weiss

Solved by LUCENE-4102.
                
> AvoidCodecs (and maybe similar nearby logic) still runs BeforeClass
> -------------------------------------------------------------------
>
>                 Key: LUCENE-4125
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4125
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>            Assignee: Dawid Weiss
>             Fix For: 4.0, 5.0
>
>
> ant test-core -Dtestcase=TestBackwardsCompatibility -Dtests.codec=Lucene3x
> This test isnt allowed to run Lucene3x, but the assumption stuff is per-method, it still loads things up in beforeClass, meaning we checkindex() real 3.x segments with the "fake" 3.x impersonator and it looks like corruption, which is really scary if you are just trying to run all the tests with -Dtests.codec=Lucene3x to verify a change doesnt break backwards compat.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org