You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by se...@apache.org on 2014/10/10 17:54:32 UTC

svn commit: r1630929 - /jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/BooleanPropertyEditor.java

Author: sebb
Date: Fri Oct 10 15:54:31 2014
New Revision: 1630929

URL: http://svn.apache.org/r1630929
Log:
Document why the mixed case values are used

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/BooleanPropertyEditor.java

Modified: jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/BooleanPropertyEditor.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/BooleanPropertyEditor.java?rev=1630929&r1=1630928&r2=1630929&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/BooleanPropertyEditor.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/BooleanPropertyEditor.java Fri Oct 10 15:54:31 2014
@@ -25,7 +25,12 @@ import java.beans.PropertyEditorSupport;
  */
 public class BooleanPropertyEditor extends PropertyEditorSupport {
 
-    private static final String[] TAGS = {"True", "False"}; // $NON-NLS-1$
+    // These are the mixed-case values as returned by the RI JVM boolean property editor
+    // However, they are different from the lower-case values returned by e.g. Boolean.FALSE.toString() 
+    private static final String FALSE = "False"; // $NON-NLS-1$
+    private static final String TRUE = "True";   // $NON-NLS-1$
+
+    private static final String[] TAGS = {TRUE, FALSE};
 
     @Override
     public void setAsText(String text) {