You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2007/10/04 22:01:50 UTC
[jira] Created: (WICKET-1041) Fix a TODO for 1.3 at
AjaxFormSubmitBehavior.onError()
Fix a TODO for 1.3 at AjaxFormSubmitBehavior.onError()
------------------------------------------------------
Key: WICKET-1041
URL: https://issues.apache.org/jira/browse/WICKET-1041
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.3.0-beta3
Reporter: Martin Grigorov
Priority: Trivial
Fix For: 1.3.0-beta4
There is the following TODO at org/apache/wicket/ajax/form/AjaxFormSubmitBehavior.onError():
/**
* Listener method invoked when the form has been processed and errors occured
*
* @param target
*
* TODO 1.3: make abstract to be consistent with onsubmit()
*
*/
protected void onError(AjaxRequestTarget target)
{
}
Should this be done for 1.3 or it will stay like it is now for the next major release ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1041) Fix a TODO for 1.3 at
AjaxFormSubmitBehavior.onError()
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534549 ]
Igor Vaynberg commented on WICKET-1041:
---------------------------------------
because this is ajax, not a regular request. if you do not implement onerror() and you have a form validation error the user will not see any feedback.
> Fix a TODO for 1.3 at AjaxFormSubmitBehavior.onError()
> ------------------------------------------------------
>
> Key: WICKET-1041
> URL: https://issues.apache.org/jira/browse/WICKET-1041
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta3
> Reporter: Martin Grigorov
> Assignee: Igor Vaynberg
> Priority: Trivial
> Fix For: 1.3.0-beta4
>
>
> There is the following TODO at org/apache/wicket/ajax/form/AjaxFormSubmitBehavior.onError():
> /**
> * Listener method invoked when the form has been processed and errors occured
> *
> * @param target
> *
> * TODO 1.3: make abstract to be consistent with onsubmit()
> *
> */
> protected void onError(AjaxRequestTarget target)
> {
> }
> Should this be done for 1.3 or it will stay like it is now for the next major release ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1041) Fix a TODO for 1.3 at
AjaxFormSubmitBehavior.onError()
Posted by "Kent Tong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534546 ]
Kent Tong commented on WICKET-1041:
-----------------------------------
Why should it be abstract? In Form.java, onSubmit() is abstract but onError is not. This is good because normally people only use onSubmit(). Now AjaxFormSubmitBehavior is inconsistent with Form.
> Fix a TODO for 1.3 at AjaxFormSubmitBehavior.onError()
> ------------------------------------------------------
>
> Key: WICKET-1041
> URL: https://issues.apache.org/jira/browse/WICKET-1041
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta3
> Reporter: Martin Grigorov
> Assignee: Igor Vaynberg
> Priority: Trivial
> Fix For: 1.3.0-beta4
>
>
> There is the following TODO at org/apache/wicket/ajax/form/AjaxFormSubmitBehavior.onError():
> /**
> * Listener method invoked when the form has been processed and errors occured
> *
> * @param target
> *
> * TODO 1.3: make abstract to be consistent with onsubmit()
> *
> */
> protected void onError(AjaxRequestTarget target)
> {
> }
> Should this be done for 1.3 or it will stay like it is now for the next major release ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1041) Fix a TODO for 1.3 at
AjaxFormSubmitBehavior.onError()
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-1041.
-----------------------------------
Resolution: Fixed
> Fix a TODO for 1.3 at AjaxFormSubmitBehavior.onError()
> ------------------------------------------------------
>
> Key: WICKET-1041
> URL: https://issues.apache.org/jira/browse/WICKET-1041
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta3
> Reporter: Martin Grigorov
> Assignee: Igor Vaynberg
> Priority: Trivial
> Fix For: 1.3.0-beta4
>
>
> There is the following TODO at org/apache/wicket/ajax/form/AjaxFormSubmitBehavior.onError():
> /**
> * Listener method invoked when the form has been processed and errors occured
> *
> * @param target
> *
> * TODO 1.3: make abstract to be consistent with onsubmit()
> *
> */
> protected void onError(AjaxRequestTarget target)
> {
> }
> Should this be done for 1.3 or it will stay like it is now for the next major release ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1041) Fix a TODO for 1.3 at
AjaxFormSubmitBehavior.onError()
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reassigned WICKET-1041:
-------------------------------------
Assignee: Igor Vaynberg
> Fix a TODO for 1.3 at AjaxFormSubmitBehavior.onError()
> ------------------------------------------------------
>
> Key: WICKET-1041
> URL: https://issues.apache.org/jira/browse/WICKET-1041
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta3
> Reporter: Martin Grigorov
> Assignee: Igor Vaynberg
> Priority: Trivial
> Fix For: 1.3.0-beta4
>
>
> There is the following TODO at org/apache/wicket/ajax/form/AjaxFormSubmitBehavior.onError():
> /**
> * Listener method invoked when the form has been processed and errors occured
> *
> * @param target
> *
> * TODO 1.3: make abstract to be consistent with onsubmit()
> *
> */
> protected void onError(AjaxRequestTarget target)
> {
> }
> Should this be done for 1.3 or it will stay like it is now for the next major release ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.