You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/06/30 22:12:58 UTC

[PR] [SPARK-57788] Prevent Build CI cancellation between different commits [spark-kubernetes-operator]

dongjoon-hyun opened a new pull request, #720:
URL: https://github.com/apache/spark-kubernetes-operator/pull/720

   ### What changes were proposed in this pull request?
   
   This PR adds `${{ github.sha }}` to the `concurrency.group` key of the `Build` workflow so the group is scoped per commit instead of per branch.
   
   ### Why are the changes needed?
   
   With the branch-only key, all `Build` runs on a branch shared one group, and `cancel-in-progress: true` made unrelated runs cancel each other. Re-running an older commit's failed jobs on `main` cancelled the newest commit's in-progress CI. Scoping by commit SHA still cancels a stale run for the same commit, but no longer cancels runs for different commits.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Manual review.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Opus 4.8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-57788] Prevent Build CI cancellation between different commits in `main` branch [spark-kubernetes-operator]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #720: [SPARK-57788] Prevent Build CI cancellation between different commits in `main` branch
URL: https://github.com/apache/spark-kubernetes-operator/pull/720


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-57788] Prevent Build CI cancellation between different commits in `main` branch [spark-kubernetes-operator]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #720:
URL: https://github.com/apache/spark-kubernetes-operator/pull/720#issuecomment-4849849601

   Merged to main


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-57788] Prevent Build CI cancellation between different commits in `main` branch [spark-kubernetes-operator]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #720:
URL: https://github.com/apache/spark-kubernetes-operator/pull/720#issuecomment-4848483016

   Thank you, @viirya !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org