You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/06/30 16:54:14 UTC

[GitHub] [bookkeeper] lordcheng10 commented on a diff in pull request #3260: Optimize write cache: supports configuring multiple caches

lordcheng10 commented on code in PR #3260:
URL: https://github.com/apache/bookkeeper/pull/3260#discussion_r911252702


##########
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorageWriteCacheTest.java:
##########
@@ -132,15 +145,15 @@ public void writeCacheFull() throws Exception {
         assertEquals("key", new String(storage.readMasterKey(4)));
 
         // Add enough entries to fill the 1st write cache
-        for (int i = 0; i < 5; i++) {
+        for (int i = 0; i < 10; i++) {

Review Comment:
   To test multiple write cache blocks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org