You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Aleksandr Efimov (Code Review)" <ge...@cloudera.org> on 2026/10/05 12:06:55 UTC

[kudu-CR] [net] preserve errno from failed recv()

Aleksandr Efimov has uploaded this change for review. ( http://gerrit.cloudera.org:8080/25016


Change subject: [net] preserve errno from failed recv()
......................................................................

[net] preserve errno from failed recv()

Socket::Recv() calls GetPeerAddress() before saving errno. If the
peer lookup also fails, it can replace the original receive error
with its own error, such as ENOTCONN.

Save errno before the peer lookup. Add a regression test that makes
GetPeerAddress() overwrite errno and verifies that Recv() returns
the original EAGAIN. The EOF path continues to report ESHUTDOWN.

Testing: socket-test, all 7 tests pass. The new regression test fails
with ENOTCONN instead of EAGAIN before the fix.

Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
---
M src/kudu/util/net/socket-test.cc
M src/kudu/util/net/socket.cc
2 files changed, 29 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/25016/1
-- 
To view, visit http://gerrit.cloudera.org:8080/25016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
Gerrit-Change-Number: 25016
Gerrit-PatchSet: 1
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>

[kudu-CR] [net] preserve errno from failed recv()

Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/25016 )

Change subject: [net] preserve errno from failed recv()
......................................................................


Patch Set 1:

(2 comments)

Overall looks good to me.
Just one suggestion to add end-to-end test and a nit.

http://gerrit.cloudera.org:8080/#/c/25016/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/25016/1//COMMIT_MSG@9
PS1, Line 9: If the
           : peer lookup also fails
nit: Maybe mention - After a connection reset, peer lookup fails...


http://gerrit.cloudera.org:8080/#/c/25016/1/src/kudu/util/net/socket-test.cc
File src/kudu/util/net/socket-test.cc:

http://gerrit.cloudera.org:8080/#/c/25016/1/src/kudu/util/net/socket-test.cc@281
PS1, Line 281: TestRecvPreservesErrnoWhenPeerLookupFails
Along with this, consider adding an end-to-end test without fault injection.



-- 
To view, visit http://gerrit.cloudera.org:8080/25016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
Gerrit-Change-Number: 25016
Gerrit-PatchSet: 1
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 05 Oct 2026 13:24:56 +0000
Gerrit-HasComments: Yes

[kudu-CR] [net] preserve errno from failed recv()

Posted by "Aleksandr Efimov (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Ashwani Raina, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/25016

to look at the new patch set (#3).

Change subject: [net] preserve errno from failed recv()
......................................................................

[net] preserve errno from failed recv()

Socket::Recv() calls GetPeerAddress() before saving errno. After a
connection reset, peer lookup also fails and can replace the original
ECONNRESET with ENOTCONN.

Save errno before the peer lookup. Keep the fault-injection regression
test and add a real TCP reset test for IPv4 and IPv6. Use SetLinger()
to close the accepted socket with zero linger and verify that Recv()
reports ECONNRESET with the expected error text. The EOF path still
reports ESHUTDOWN.

Testing: all 8 socket-test tests pass. The real TCP reset test passes
100 repetitions. Focused native build, cpplint and diff check pass.

Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
---
M src/kudu/util/net/socket-test.cc
M src/kudu/util/net/socket.cc
M src/kudu/util/net/socket.h
3 files changed, 62 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/25016/3
-- 
To view, visit http://gerrit.cloudera.org:8080/25016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
Gerrit-Change-Number: 25016
Gerrit-PatchSet: 3
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [net] preserve errno from failed recv()

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25016 )

Change subject: [net] preserve errno from failed recv()
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/3080/


-- 
To view, visit http://gerrit.cloudera.org:8080/25016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
Gerrit-Change-Number: 25016
Gerrit-PatchSet: 2
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 05 Oct 2026 17:31:52 +0000
Gerrit-HasComments: No

[kudu-CR] [net] preserve errno from failed recv()

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [net] preserve errno from failed recv()
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/25016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
Gerrit-Change-Number: 25016
Gerrit-PatchSet: 1
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [net] preserve errno from failed recv()

Posted by "Aleksandr Efimov (Code Review)" <ge...@cloudera.org>.
Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/25016 )

Change subject: [net] preserve errno from failed recv()
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/25016/2/src/kudu/util/net/socket-test.cc
File src/kudu/util/net/socket-test.cc:

http://gerrit.cloudera.org:8080/#/c/25016/2/src/kudu/util/net/socket-test.cc@327
PS2, Line 327:     const struct linger reset_linger = {1, 0};
             :     ASSERT_EQ(0, setsockopt(server.GetFd(), SOL_SOCKET, SO_LINGER,
             :                            &reset_linger, sizeof(reset_linger)));
> nit: could use Socket::SetLinger(bool enable, int linger_timeout_sec = 0) h
Used SetLinger(true) in PS3, with FRIEND_TEST for the private helper.



-- 
To view, visit http://gerrit.cloudera.org:8080/25016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
Gerrit-Change-Number: 25016
Gerrit-PatchSet: 2
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 06 Oct 2026 08:05:56 +0000
Gerrit-HasComments: Yes

[kudu-CR] [net] preserve errno from failed recv()

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/25016 )

Change subject: [net] preserve errno from failed recv()
......................................................................


Patch Set 1: Verified+1

Unrelated test failures of known flaky tests:
  * DEBUG: KUDU-3574
  * TSAN: KUDU-3481


-- 
To view, visit http://gerrit.cloudera.org:8080/25016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
Gerrit-Change-Number: 25016
Gerrit-PatchSet: 1
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 05 Oct 2026 14:38:58 +0000
Gerrit-HasComments: No

[kudu-CR] [net] preserve errno from failed recv()

Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/25016 )

Change subject: [net] preserve errno from failed recv()
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/25016/1/src/kudu/util/net/socket-test.cc
File src/kudu/util/net/socket-test.cc:

http://gerrit.cloudera.org:8080/#/c/25016/1/src/kudu/util/net/socket-test.cc@281
PS1, Line 281: TestRecvPreservesErrnoWhenPeerLookupFails
> I guess we do have a bunch of end-to-end tests that exercise Socket::Recv()
Sure! I guess the idea is to run the test without overriding the GetPeerAddress() (getpeername()) from base class Socket, covering real syscall behavior.

Something like:
BindAndListen
Connect client
Accept and close on server-side
client->Recv

it should get ECONNRESET with apt error string.

It is not a must have but it gives a test coverage on actual underlying syscall behavior.



-- 
To view, visit http://gerrit.cloudera.org:8080/25016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
Gerrit-Change-Number: 25016
Gerrit-PatchSet: 1
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 05 Oct 2026 17:03:28 +0000
Gerrit-HasComments: Yes

[kudu-CR] [net] preserve errno from failed recv()

Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/25016 )

Change subject: [net] preserve errno from failed recv()
......................................................................


Patch Set 3: Code-Review+2

Thanks for addressing the comments.


-- 
To view, visit http://gerrit.cloudera.org:8080/25016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
Gerrit-Change-Number: 25016
Gerrit-PatchSet: 3
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 06 Oct 2026 10:04:43 +0000
Gerrit-HasComments: No

[kudu-CR] [net] preserve errno from failed recv()

Posted by "Aleksandr Efimov (Code Review)" <ge...@cloudera.org>.
Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/25016 )

Change subject: [net] preserve errno from failed recv()
......................................................................


Patch Set 1:

Could someone share the failure log from https://jenkins.kudu.apache.org/job/pre_commit/3079/? Thanks!


-- 
To view, visit http://gerrit.cloudera.org:8080/25016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
Gerrit-Change-Number: 25016
Gerrit-PatchSet: 1
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 05 Oct 2026 12:54:26 +0000
Gerrit-HasComments: No

[kudu-CR] [net] preserve errno from failed recv()

Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/25016 )

Change subject: [net] preserve errno from failed recv()
......................................................................


Patch Set 3: Verified+1

unrelated failures


-- 
To view, visit http://gerrit.cloudera.org:8080/25016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
Gerrit-Change-Number: 25016
Gerrit-PatchSet: 3
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 06 Oct 2026 11:11:56 +0000
Gerrit-HasComments: No

[kudu-CR] [net] preserve errno from failed recv()

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25016 )

Change subject: [net] preserve errno from failed recv()
......................................................................


Patch Set 3:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/3081/


-- 
To view, visit http://gerrit.cloudera.org:8080/25016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
Gerrit-Change-Number: 25016
Gerrit-PatchSet: 3
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 06 Oct 2026 08:05:31 +0000
Gerrit-HasComments: No

[kudu-CR] [net] preserve errno from failed recv()

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25016 )

Change subject: [net] preserve errno from failed recv()
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/3079/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/25016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
Gerrit-Change-Number: 25016
Gerrit-PatchSet: 1
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 05 Oct 2026 12:44:31 +0000
Gerrit-HasComments: No

[kudu-CR] [net] preserve errno from failed recv()

Posted by "Aleksandr Efimov (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Ashwani Raina, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/25016

to look at the new patch set (#2).

Change subject: [net] preserve errno from failed recv()
......................................................................

[net] preserve errno from failed recv()

Socket::Recv() calls GetPeerAddress() before saving errno. After a
connection reset, peer lookup also fails and can replace the original
ECONNRESET with ENOTCONN.

Save errno before the peer lookup. Keep the fault-injection regression
test and add a real TCP reset test for IPv4 and IPv6. Close the accepted
socket with zero linger and verify that Recv() reports ECONNRESET
with the expected error text. The EOF path still reports ESHUTDOWN.

Testing: all 8 socket-test tests pass. The new TCP reset test passes
100 repetitions and fails with ENOTCONN instead of ECONNRESET without
the fix.

Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
---
M src/kudu/util/net/socket-test.cc
M src/kudu/util/net/socket.cc
2 files changed, 63 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/25016/2
-- 
To view, visit http://gerrit.cloudera.org:8080/25016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
Gerrit-Change-Number: 25016
Gerrit-PatchSet: 2
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [net] preserve errno from failed recv()

Posted by "Aleksandr Efimov (Code Review)" <ge...@cloudera.org>.
Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/25016 )

Change subject: [net] preserve errno from failed recv()
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/25016/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/25016/1//COMMIT_MSG@9
PS1, Line 9: If the
           : peer lookup also fails
> nit: Maybe mention - After a connection reset, peer lookup fails...
Clarified in PS2.


http://gerrit.cloudera.org:8080/#/c/25016/1/src/kudu/util/net/socket-test.cc
File src/kudu/util/net/socket-test.cc:

http://gerrit.cloudera.org:8080/#/c/25016/1/src/kudu/util/net/socket-test.cc@281
PS1, Line 281: TestRecvPreservesErrnoWhenPeerLookupFails
> Along with this, consider adding an end-to-end test without fault injection
Added in PS2, covering IPv4 and IPv6.



-- 
To view, visit http://gerrit.cloudera.org:8080/25016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
Gerrit-Change-Number: 25016
Gerrit-PatchSet: 1
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 05 Oct 2026 17:50:00 +0000
Gerrit-HasComments: Yes

[kudu-CR] [net] preserve errno from failed recv()

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/25016 )

Change subject: [net] preserve errno from failed recv()
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/25016/1/src/kudu/util/net/socket-test.cc
File src/kudu/util/net/socket-test.cc:

http://gerrit.cloudera.org:8080/#/c/25016/1/src/kudu/util/net/socket-test.cc@281
PS1, Line 281: TestRecvPreservesErrnoWhenPeerLookupFails
> Along with this, consider adding an end-to-end test without fault injection
I guess we do have a bunch of end-to-end tests that exercise Socket::Recv() without fault injection (e.g., there is a bunch in rpc-test.cc at least).

Ashwani, do you have any special test scenario in mind for the mentioned end-to-end test to cover?



-- 
To view, visit http://gerrit.cloudera.org:8080/25016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
Gerrit-Change-Number: 25016
Gerrit-PatchSet: 1
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 05 Oct 2026 14:27:19 +0000
Gerrit-HasComments: Yes

[kudu-CR] [net] preserve errno from failed recv()

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/25016 )

Change subject: [net] preserve errno from failed recv()
......................................................................

[net] preserve errno from failed recv()

Socket::Recv() calls GetPeerAddress() before saving errno. After a
connection reset, peer lookup also fails and can replace the original
ECONNRESET with ENOTCONN.

Save errno before the peer lookup. Keep the fault-injection regression
test and add a real TCP reset test for IPv4 and IPv6. Use SetLinger()
to close the accepted socket with zero linger and verify that Recv()
reports ECONNRESET with the expected error text. The EOF path still
reports ESHUTDOWN.

Testing: all 8 socket-test tests pass. The real TCP reset test passes
100 repetitions. Focused native build, cpplint and diff check pass.

Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
Reviewed-on: http://gerrit.cloudera.org:8080/25016
Reviewed-by: Ashwani Raina <ar...@gmail.com>
Tested-by: Ashwani Raina <ar...@gmail.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/util/net/socket-test.cc
M src/kudu/util/net/socket.cc
M src/kudu/util/net/socket.h
3 files changed, 62 insertions(+), 1 deletion(-)

Approvals:
  Ashwani Raina: Looks good to me, approved; Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/25016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
Gerrit-Change-Number: 25016
Gerrit-PatchSet: 4
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [net] preserve errno from failed recv()

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/25016 )

Change subject: [net] preserve errno from failed recv()
......................................................................


Patch Set 3: Code-Review+2

Thank you for fixing this!


-- 
To view, visit http://gerrit.cloudera.org:8080/25016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
Gerrit-Change-Number: 25016
Gerrit-PatchSet: 3
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 06 Oct 2026 13:59:39 +0000
Gerrit-HasComments: No

[kudu-CR] [net] preserve errno from failed recv()

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/25016 )

Change subject: [net] preserve errno from failed recv()
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/25016/2/src/kudu/util/net/socket-test.cc
File src/kudu/util/net/socket-test.cc:

http://gerrit.cloudera.org:8080/#/c/25016/2/src/kudu/util/net/socket-test.cc@327
PS2, Line 327:     const struct linger reset_linger = {1, 0};
             :     ASSERT_EQ(0, setsockopt(server.GetFd(), SOL_SOCKET, SO_LINGER,
             :                            &reset_linger, sizeof(reset_linger)));
nit: could use Socket::SetLinger(bool enable, int linger_timeout_sec = 0) here instead of invoking syscall explicitly?



-- 
To view, visit http://gerrit.cloudera.org:8080/25016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
Gerrit-Change-Number: 25016
Gerrit-PatchSet: 2
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 05 Oct 2026 22:53:06 +0000
Gerrit-HasComments: Yes

[kudu-CR] [net] preserve errno from failed recv()

Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has removed a vote on this change.

Change subject: [net] preserve errno from failed recv()
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/25016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
Gerrit-Change-Number: 25016
Gerrit-PatchSet: 3
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [net] preserve errno from failed recv()

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25016 )

Change subject: [net] preserve errno from failed recv()
......................................................................


Patch Set 3: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/3081/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/25016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
Gerrit-Change-Number: 25016
Gerrit-PatchSet: 3
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 06 Oct 2026 08:51:54 +0000
Gerrit-HasComments: No

[kudu-CR] [net] preserve errno from failed recv()

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/25016 )

Change subject: [net] preserve errno from failed recv()
......................................................................


Patch Set 1:

> Unrelated test failures of known flaky tests:
 > * DEBUG: KUDU-3574
 > * TSAN: KUDU-3481

There was also an unrelated test failure in TSAN build due to KUDU-3813.


-- 
To view, visit http://gerrit.cloudera.org:8080/25016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
Gerrit-Change-Number: 25016
Gerrit-PatchSet: 1
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 05 Oct 2026 14:56:35 +0000
Gerrit-HasComments: No

[kudu-CR] [net] preserve errno from failed recv()

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25016 )

Change subject: [net] preserve errno from failed recv()
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/3079/


-- 
To view, visit http://gerrit.cloudera.org:8080/25016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
Gerrit-Change-Number: 25016
Gerrit-PatchSet: 1
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 05 Oct 2026 12:07:01 +0000
Gerrit-HasComments: No

[kudu-CR] [net] preserve errno from failed recv()

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/25016 )

Change subject: [net] preserve errno from failed recv()
......................................................................


Patch Set 1:

> Could someone share the failure log from https://jenkins.kudu.apache.org/job/pre_commit/3079/?
 > Thanks!

Sorry for the inconvenience -- there have been a stream of DDoS attacks on jenkins.kudu.apache.org, so we introduced white list for access control.  Also, an account with Jenkins is necessary to access the logs.  Let me know if you want/need one -- we can create it for you and add your IP address into the white list.

As for test failures, those are due to unrelated flaky tests in DEBUG and TSAN configurations.  They are well known flakes:
  * DEBUG: http://dist-test.cloudera.org/job?job_id=jenkins-slave.1791202734.1054278 (KUDU-3574)
  * TSAN: http://dist-test.cloudera.org/job?job_id=jenkins-slave.1791202595.1519159 (KUDU-3481)


-- 
To view, visit http://gerrit.cloudera.org:8080/25016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
Gerrit-Change-Number: 25016
Gerrit-PatchSet: 1
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 05 Oct 2026 14:38:03 +0000
Gerrit-HasComments: No

[kudu-CR] [net] preserve errno from failed recv()

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25016 )

Change subject: [net] preserve errno from failed recv()
......................................................................


Patch Set 2: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/3080/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/25016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b
Gerrit-Change-Number: 25016
Gerrit-PatchSet: 2
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 05 Oct 2026 18:09:05 +0000
Gerrit-HasComments: No