You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/05/08 12:47:52 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on pull request #2593: Enhance HttpUtils class and add a hello-world alert plugin example
codecov-io edited a comment on pull request #2593:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2593#issuecomment-623097834
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2593?src=pr&el=h1) Report
> Merging [#2593](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2593?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/a5b053643766ba646306bb6e351d60b3fbe4ebe8&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `79.12%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2593?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #2593 +/- ##
============================================
- Coverage 36.30% 36.26% -0.04%
- Complexity 2478 2486 +8
============================================
Files 431 434 +3
Lines 19856 19910 +54
Branches 2419 2419
============================================
+ Hits 7208 7221 +13
- Misses 12006 12043 +37
- Partials 642 646 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2593?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/dolphinscheduler/alert/runner/AlertSender.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2593/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9ydW5uZXIvQWxlcnRTZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...pache/dolphinscheduler/plugin/model/AlertData.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2593/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1wbHVnaW4tYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3BsdWdpbi9tb2RlbC9BbGVydERhdGEuamF2YQ==) | `89.28% <0.00%> (-10.72%)` | `17.00 <0.00> (ø)` | |
| [...phinscheduler/common/plugin/PluginClassLoader.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2593/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3BsdWdpbi9QbHVnaW5DbGFzc0xvYWRlci5qYXZh) | `28.30% <50.00%> (-0.55%)` | `6.00 <2.00> (ø)` | |
| [...pache/dolphinscheduler/common/utils/HttpUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2593/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0h0dHBVdGlscy5qYXZh) | `77.41% <77.41%> (+5.19%)` | `8.00 <8.00> (+5.00)` | |
| [...apache/dolphinscheduler/common/model/Response.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2593/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL21vZGVsL1Jlc3BvbnNlLmphdmE=) | `100.00% <100.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...cheduler/example/plugin/HelloworldAlertPlugin.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2593/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvaGVsbG93b3JsZC1hbGVydC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZXhhbXBsZS9wbHVnaW4vSGVsbG93b3JsZEFsZXJ0UGx1Z2luLmphdmE=) | `100.00% <100.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...inscheduler/example/plugin/HelloworldProvider.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2593/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvaGVsbG93b3JsZC1hbGVydC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZXhhbXBsZS9wbHVnaW4vSGVsbG93b3JsZFByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [.../server/worker/processor/TaskExecuteProcessor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2593/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9wcm9jZXNzb3IvVGFza0V4ZWN1dGVQcm9jZXNzb3IuamF2YQ==) | `10.00% <0.00%> (-26.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...he/dolphinscheduler/common/thread/ThreadUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2593/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9UaHJlYWRVdGlscy5qYXZh) | `68.25% <0.00%> (-9.53%)` | `13.00% <0.00%> (-2.00%)` | |
| [...nscheduler/server/entity/TaskExecutionContext.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2593/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL2VudGl0eS9UYXNrRXhlY3V0aW9uQ29udGV4dC5qYXZh) | `73.26% <0.00%> (-5.95%)` | `53.00% <0.00%> (-3.00%)` | |
| ... and [4 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2593/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2593?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2593?src=pr&el=footer). Last update [a5b0536...628129b](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2593?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org