You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "vttranlina (via GitHub)" <gi...@apache.org> on 2023/12/04 05:07:13 UTC

[PR] JAMES-2586 [PGSQL] Optimize Mailbox/Message Mapper [james-project]

vttranlina opened a new pull request, #1834:
URL: https://github.com/apache/james-project/pull/1834

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

Re: [PR] JAMES-2586 [PGSQL] Optimize Mailbox/Message Mapper [james-project]

Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 commented on PR #1834:
URL: https://github.com/apache/james-project/pull/1834#issuecomment-1841955971

   Just a remark: did you warm up James before testing?
   
   BTW 5k users looks too easy on your "super" machine :D


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

Re: [PR] JAMES-2586 [PGSQL] Optimize Mailbox/Message Mapper [james-project]

Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on PR #1834:
URL: https://github.com/apache/james-project/pull/1834#issuecomment-1841960541

   > Just a remark: did you warm up James before testing?
   
   I ran the Gatling test with duration=5m before real test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

Re: [PR] JAMES-2586 [PGSQL] Optimize Mailbox/Message Mapper [james-project]

Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on PR #1834:
URL: https://github.com/apache/james-project/pull/1834#issuecomment-1841950324

   ## Benchmarks 
   - Env: on my local PC (both run gatling & james in the same PC)
   - Sample data:
   ![image](https://github.com/apache/james-project/assets/81145350/4fab4002-14ba-4e08-b90d-6262ef7c5ca2)
   
   - The first time: Duration: 40m
   ![image](https://github.com/apache/james-project/assets/81145350/4147cda7-c23a-4f3d-8d30-d78e70a31274)
   
   - The second time. Duration 15m
   ![image](https://github.com/apache/james-project/assets/81145350/881639f0-7776-4573-b46b-3ea6b1422dba)
   
   ### Conclusion
   The better is not clear?, it will be more trust if Gatling and James are on separate servers
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

Re: [PR] JAMES-2586 [PGSQL] Optimize Mailbox/Message Mapper [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #1834:
URL: https://github.com/apache/james-project/pull/1834#issuecomment-1838503706

   Please back those changes with gatling test runs... Before and after...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

Re: [PR] JAMES-2586 [PGSQL] Optimize Mailbox/Message Mapper [james-project]

Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on PR #1834:
URL: https://github.com/apache/james-project/pull/1834#issuecomment-1840540066

   > I'll approuve when provided benchmarks backing this change ;-)
   
   yes, I'm doing it.
   It takes time to fix some guice app and provision sample data. 
   A lot of docker crash on my pc when try provision 5k users :D 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

Re: [PR] JAMES-2586 [PGSQL] Optimize Mailbox/Message Mapper [james-project]

Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on PR #1834:
URL: https://github.com/apache/james-project/pull/1834#issuecomment-1842164539

   rebase master & squash


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

Re: [PR] JAMES-2586 [PGSQL] Optimize Mailbox/Message Mapper [james-project]

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael merged PR #1834:
URL: https://github.com/apache/james-project/pull/1834


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

Re: [PR] JAMES-2586 [PGSQL] Optimize Mailbox/Message Mapper [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #1834:
URL: https://github.com/apache/james-project/pull/1834#discussion_r1413778511


##########
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/dao/PostgresMailboxDAO.java:
##########
@@ -255,4 +268,12 @@ public Mono<Pair<MessageUid, ModSeq>> incrementAndGetLastUidAndModSeq(MailboxId
                 .returning(MAILBOX_LAST_UID, MAILBOX_HIGHEST_MODSEQ)))
             .map(record -> Pair.of(MessageUid.of(record.get(MAILBOX_LAST_UID)), ModSeq.of(record.get(MAILBOX_HIGHEST_MODSEQ))));
     }
+
+    public Mono<PostgresMailbox> retrievePostgresMailbox(MailboxId mailboxId) {

Review Comment:
   YES that was my idea...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

Re: [PR] JAMES-2586 [PGSQL] Optimize Mailbox/Message Mapper [james-project]

Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on code in PR #1834:
URL: https://github.com/apache/james-project/pull/1834#discussion_r1413600296


##########
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/dao/PostgresMailboxDAO.java:
##########
@@ -255,4 +268,12 @@ public Mono<Pair<MessageUid, ModSeq>> incrementAndGetLastUidAndModSeq(MailboxId
                 .returning(MAILBOX_LAST_UID, MAILBOX_HIGHEST_MODSEQ)))
             .map(record -> Pair.of(MessageUid.of(record.get(MAILBOX_LAST_UID)), ModSeq.of(record.get(MAILBOX_HIGHEST_MODSEQ))));
     }
+
+    public Mono<PostgresMailbox> retrievePostgresMailbox(MailboxId mailboxId) {

Review Comment:
   maybe we should return `PostgresMailbox` in method `public Mono<Mailbox> findMailboxById(MailboxId id)` 
   It looks better than creating one more method for postgres variant



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

Re: [PR] JAMES-2586 [PGSQL] Optimize Mailbox/Message Mapper [james-project]

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #1834:
URL: https://github.com/apache/james-project/pull/1834#issuecomment-1842072118

   > A lot of docker crash on my pc when try provision 5k users :D
   
   don't hesitate to use james-charge-01 instead then :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

Re: [PR] JAMES-2586 [PGSQL] Optimize Mailbox/Message Mapper [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #1834:
URL: https://github.com/apache/james-project/pull/1834#issuecomment-1840516532

   I'll approuve when provided benchmarks backing this change ;-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org