You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/27 03:13:42 UTC
[GitHub] [spark] srowen opened a new pull request, #38010: [MINOR] Clarify that xxhash64 seed is 42
srowen opened a new pull request, #38010:
URL: https://github.com/apache/spark/pull/38010
### What changes were proposed in this pull request?
State that the hash seed used for xxhash64 is 42 in docs.
### Why are the changes needed?
It's somewhat non-standard not seed to 0. Users would have to know this seed to reproduce the hash value.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #38010: [MINOR] Clarify that xxhash64 seed is 42
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38010:
URL: https://github.com/apache/spark/pull/38010#issuecomment-1259152469
Merged into master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a diff in pull request #38010: [MINOR] Clarify that xxhash64 seed is 42
Posted by GitBox <gi...@apache.org>.
srowen commented on code in PR #38010:
URL: https://github.com/apache/spark/pull/38010#discussion_r980690447
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala:
##########
@@ -643,7 +643,8 @@ object Murmur3HashFunction extends InterpretedHashFunction {
* A xxHash64 64-bit hash expression.
*/
@ExpressionDescription(
- usage = "_FUNC_(expr1, expr2, ...) - Returns a 64-bit hash value of the arguments.",
+ usage = "_FUNC_(expr1, expr2, ...) - Returns a 64-bit hash value of the arguments. " +
Review Comment:
We could arguably document the same about hash() above, but, it doesn't even state it's murmur3, and maybe that's on purpose, so didn't seem necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #38010: [MINOR] Clarify that xxhash64 seed is 42
Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #38010: [MINOR] Clarify that xxhash64 seed is 42
URL: https://github.com/apache/spark/pull/38010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org