You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/05/11 00:09:44 UTC

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5465: [TIR] Convert if_then_else intrinsics to if-statements

tqchen commented on a change in pull request #5465:
URL: https://github.com/apache/incubator-tvm/pull/5465#discussion_r422721228



##########
File path: src/tir/transforms/thread_storage_sync.cc
##########
@@ -95,8 +95,6 @@ class ThreadSyncPlanner : public StorageAccessVisitor {
         }
       }
       if (sync_before_stmt) {
-        CHECK_EQ(condition_counter(), 0)
-            << "Cannot insert syncs inside condition";

Review comment:
       This check is necessary for GPUs




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org