You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "svogl (via GitHub)" <gi...@apache.org> on 2024/01/18 10:41:45 UTC
[PR] GUACAMOLE-1903 set rcMask to NULL [guacamole-server]
svogl opened a new pull request, #480:
URL: https://github.com/apache/guacamole-server/pull/480
set rcMask to NULL to prevent double-free errors occuring in libvncclient 0.9.13 and up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1903: set rcMask to NULL [guacamole-server]
Posted by "svogl (via GitHub)" <gi...@apache.org>.
svogl commented on PR #480:
URL: https://github.com/apache/guacamole-server/pull/480#issuecomment-1898405499
@necouchman thanks for the suggestions, done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1903: set rcMask to NULL [guacamole-server]
Posted by "svogl (via GitHub)" <gi...@apache.org>.
svogl closed pull request #480: GUACAMOLE-1903: set rcMask to NULL
URL: https://github.com/apache/guacamole-server/pull/480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1903: set rcMask to NULL [guacamole-server]
Posted by "svogl (via GitHub)" <gi...@apache.org>.
svogl commented on PR #480:
URL: https://github.com/apache/guacamole-server/pull/480#issuecomment-1898606963
hmm, ok - never rebased a PR.... will create a new PR against the staging branch and dump this one...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1903: set rcMask to NULL [guacamole-server]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #480:
URL: https://github.com/apache/guacamole-server/pull/480#issuecomment-1898451566
> @necouchman thanks for the suggestions, done!
Unfortunately I think you'll need to rebase in git and then push - the PR now has 129 commits on it ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1903 set rcMask to NULL [guacamole-server]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #480:
URL: https://github.com/apache/guacamole-server/pull/480#issuecomment-1898306760
@svogl Thanks for this - I'm good overall with the change, but have two requests:
* Both the PR and the commit message need to be adjusted slightly so that there is a ":" after the Jira issue - e.g. "GUACAMOLE-1903: Set rcMask to NULL".
* Could you also rebase this change, and adjust the pull request, against the staging/1.5.5 branch, instead of master, so that we can pull it in as a bugfix to the 1.5.5 release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org