Re: [PR] [SPARK-54598][PYTHON] Extract logic to read UDFs [spark]

["gaogaotiantian (via GitHub)" <gi...@apache.org>]

gaogaotiantian commented on code in PR #53330:
URL: https://github.com/apache/spark/pull/53330#discussion_r2591112653


##########
python/pyspark/worker.py:
##########
@@ -2919,7 +2919,15 @@ def read_udfs(pickleSer, infile, eval_type):
     else:
         profiler = None
 
+    # Read all UDFs
     num_udfs = read_int(infile)
+    udfs = []

Review Comment:
   Is there a reason you don't like the list comprehension here? It's very commonly used, significantly faster (doesn't matter here because the function itself is super slow) and use less code. Do you have concerns for readability?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org