You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:52:36 UTC
[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on a change in pull request #3322: [FIX_BUG][*] fix some bugs from sonar analysis
CalvinKirs commented on a change in pull request #3322:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3322#discussion_r461295608
##########
File path: dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/zk/ZookeeperCachedOperator.java
##########
@@ -83,6 +83,7 @@ public void close() {
try {
Thread.sleep(500);
} catch (InterruptedException ignore) {
+ Thread.currentThread().interrupt();
Review comment:
> why not simply remove the catch block ?
Thank you very much for your suggestion, I will finish it later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org